-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: added eCHIS Kenya Training & Testing Instances & updated branding #375
base: master
Are you sure you want to change the base?
Conversation
@alexosugo once done, will this be in playstore? I really dont want the CHPs to use the browser. |
@christinawere finalising testing locally |
<instance name="eCHIS Training 1">https://chis-training.health.go.ke</instance> | ||
<instance name="eCHIS Training 2">https://chis-training-2.health.go.ke</instance> | ||
<instance name="eCHIS Training 3">https://chis-training-3.health.go.ke</instance> | ||
<instance name="eCHIS Testing">https://chis-4-testing.health.go.ke</instance> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious naming for this instance as there are no testing 1-3 instances. It seems the intention was to continue naming according to training instance sequence.
<instance name="eCHIS Testing">https://chis-4-testing.health.go.ke</instance> | |
<instance name="eCHIS Testing 4">https://chis-4-testing.health.go.ke</instance> |
I've made an attempt to regenerate secrets using the keystore provided by Ian and the bundle signing key ended up being different so training cannot be updated. I'm attaching it here if anyone needs to review. |
@eljhkrr When was the training last updated on Play Store and do we know by whom? I assume that by removing and republishing the app afresh, the review time will be longer since it'll be treated as a new app. |
Last update was in September 2023 probably by Ian who has since left MoH. We've tried getting credentials used then and they're not the same as used to publish to the playstore. It's a one-time thing, once we have automated builds setup, publishing updates will be a lot smoother. |
We've published an update to the app and can merge after secrets have been setup |
I can help add secrets to this repo. Is it correct that we just need these 4 added?
The other two in 1pass don't need a secret as far as I can tell as their common knowledge. GH has an upper bounds of secrets so we want to use them sparingly. |
Thanks @mrjones-plip, just the 4 will do |
3 secrets created. I did not create |
This pull request does the following things: