fix(#198): add configurable POSTGRES_PORT to docker compose file #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert <rmayore@livinggoods.org>
jkuester
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Everywhere that is currently referencing 5432 in the code is also checking the POSTGRES_PORT value. Additionally, the env.template file already has an entry for POSTGRES_PORT. So, I believe this change should be good to go!
(I am assuming this previous hard-coded configuration in the docker-compose was just an oversight that was made when overhauling everything to just use couch2pg.)
jkuester
changed the title
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds configurable PG port
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.