-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(#28): fixed make prod
bug
#30
Conversation
make prod
bug
I managed to reproduce @mrjones-plip's bug locally on the If I run
|
@andrablaj You'll to setup a PostgreSQL database and update the following environment variables: DBT_POSTGRES_HOST=
DBT_POSTGRES_USER=
DBT_POSTGRES_PASSWORD=
POSTGRES_DB=
POSTGRES_TABLE=
DBT_POSTGRES_SCHEMA=
POSTGRES_SCHEMA= |
@andrablaj - I'm waaaay behind on my mail/slack/todo queue - removing myself as a reviewer to unblock. |
Unassigning myself as a reviewer for now since I am away today and on Monday |
make prod
bugmake prod
bug
@samuelimoisili, following up here with some items from our 1:1 discussion:
Thanks! |
Is this PR still relevant given you do away with the makefile in this PR? |
@njogz Yes, it is relevant. It introduces a new docker-compose file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎆 Awesome, I managed to run make prod
successfully locally, with the latest CHT run via docker helper. Great job!
Nevertheless, the documentation needs updates as I needed to perform extra steps to have this running correctly.
- Content of
.env
:
# project wide: optional
COMPOSE_PROJECT_NAME=pipeline
# postgrest and pogresql: required environment variables for 'gamma', prod and 'local'
POSTGRES_USER=root
POSTGRES_PASSWORD=supercoolpassword
POSTGRES_DB=data
POSTGRES_TABLE=couchdb
POSTGRES_SCHEMA=v1
# dbt: required environment variables for 'gamma', 'prod' and 'local'
DBT_POSTGRES_USER=dbt_user
DBT_POSTGRES_PASSWORD=supercoolpassword
DBT_POSTGRES_SCHEMA=dbt
DBT_POSTGRES_HOST=yourIP
CHT_PIPELINE_BRANCH_URL=https://github.com/medic/cht-pipeline.git#main
# couchdb and logstash: required environment variables for 'gamma', 'prod' and 'local'
COUCHDB_USER=medic
COUCHDB_PASSWORD=password
COUCHDB_DB=medic-users-meta
COUCHDB_HOST=yourCHThost
COUCHDB_PORT=yourCHTport
COUCHDB_SECURE=false
# superset: required environment variables for 'gamma', 'prod' and 'local'
SUPERSET_PASSWORD=password
SUPERSET_ADMIN_EMAIL=user@superset.com
- Run
make prod
- Run
docker-compose -f docker-compose.postgres.yml -f docker-compose.yml up postgres
.
I think it's worth mentioning that the user can skip step 3 if they have a local instance of postgreSQL, and update .env
accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Andra Blaj <blajandra@gmail.com>
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Added a docker compose file to fix
make prod
postgrest startup issue.Closes #28