Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ginkgo mismatch version #84

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Mar 16, 2023

Ginkgo version in Makefile is v2.9.1, while on go.mod it is only 2.8.0

Ginkgo version in Makefile is v2.9.1, while on go.mod it is only 2.8.0
@openshift-ci openshift-ci bot requested review from beekhof and clobrano March 16, 2023 08:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Mar 16, 2023

/retest

@clobrano
Copy link
Contributor

/lgtm

Giving others a chance to review as well, feel free to unhold
/hold

@razo7
Copy link
Member Author

razo7 commented Mar 20, 2023

/unhold

@openshift-merge-robot openshift-merge-robot merged commit a2f16d0 into medik8s:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants