graceful setup and start

src/Xssless.php

@@ -24,26 +24,28 @@ public function clean(string $html, ?ConfigInterface $tempConfig = null): string
         };
     }
 
-    public function start(?ConfigInterface $tempConfig = null): ServiceInterface
+    public function start(?ConfigInterface $tempConfig = null): ?ServiceInterface
     {
         $service = $this->makeCleaner($tempConfig);
 
         if (! $service instanceof ServiceInterface) {
-            throw new XsslessException("'".$service::class."' must implement: '".ServiceInterface::class."'.");
+            return null;
         }
 
         return $service->start();
     }
 
-    public function setup(?ConfigInterface $tempConfig = null): void
+    public function setup(?ConfigInterface $tempConfig = null): bool
     {
-        $service = $this->makeCleaner($tempConfig);
+        $cleaner = $this->makeCleaner($tempConfig);
 
-        if (! $service instanceof HasSetupInterface) {
-            throw new XsslessException("'".$service::class."' must implement: '".HasSetupInterface::class."'.");
+        if (! $cleaner instanceof HasSetupInterface) {
+            return false;
         }
 
-        $service->setup();
+        $cleaner->setup();
+
+        return true;
     }
 
     public function usingLaravelConfig(): static

src/laravel/Commands/SetupCommand.php

@@ -16,6 +16,8 @@ class SetupCommand extends Command
     public function handle(): void
     {
         // TODO: non Laravel command
-        Xssless::usingLaravelConfig()->setup();
+        Xssless::usingLaravelConfig()->setup() ?
+            $this->info('Setup done.') :
+            $this->info('The current driver has no setup.');
     }
 }

src/laravel/Commands/StartCommand.php

@@ -3,6 +3,7 @@
 namespace Medilies\Xssless\Laravel\Commands;
 
 use Illuminate\Console\Command;
+use Medilies\Xssless\Interfaces\ServiceInterface;
 use Medilies\Xssless\Laravel\Facades\Xssless;
 
 class StartCommand extends Command
@@ -18,15 +19,13 @@ public function handle(): void
         // TODO: non Laravel command
         $service = Xssless::usingLaravelConfig()->start();
 
-        $terminate = function ($signal) use ($service) {
-            $this->warn("Terminating...\n");
-            $service->stop();
-            exit;
-        };
+        if (is_null($service)) {
+            $this->info('The current driver is not a service to start.');
 
-        // ? Is this necessary
-        pcntl_signal(SIGTERM, $terminate);
-        pcntl_signal(SIGINT, $terminate);
+            return;
+        }
+
+        $this->onTermination($service);
 
         while ($service->isRunning()) {
             $output = $service->getIncrementalOutput();
@@ -44,4 +43,20 @@ public function handle(): void
             usleep(100_000);
         }
     }
+
+    private function onTermination(ServiceInterface $service): void
+    {
+        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN' || ! extension_loaded('pcntl')) {
+            return;
+        }
+
+        $terminate = function ($signal) use ($service) {
+            $this->warn("Terminating...\n");
+            $service->stop();
+            exit;
+        };
+
+        pcntl_signal(SIGTERM, $terminate);
+        pcntl_signal(SIGINT, $terminate);
+    }
 }

src/laravel/Facades/Xssless.php

@@ -8,8 +8,8 @@
 
 /**
  * @method static string clean(string $html, ?ConfigInterface $config = null)
- * @method static ServiceInterface start(?ConfigInterface $config = null)
- * @method static void setup(?ConfigInterface $config = null)
+ * @method static ?ServiceInterface start(?ConfigInterface $config = null)
+ * @method static bool setup(?ConfigInterface $config = null)
  * @method static static usingLaravelConfig()
  * @method static static using(ConfigInterface $config)
  *

tests/Dompurify/DompurifyCliTest.php

@@ -49,7 +49,7 @@
 test('setup()', function () {
     $cleaner = (new Xssless)->using(new DompurifyCliConfig);
 
-    expect(fn () => $cleaner->setup())->not->toThrow(Exception::class);
+    expect($cleaner->setup())->toBeTrue();
 });
 
 test('exec()', function () {

tests/Dompurify/DompurifyServiceTest.php

@@ -51,9 +51,9 @@
 // ----------------------------------------------------------------------------
 
 test('setup()', function () {
-    $cleaner = (new DompurifyService)->configure(new DompurifyServiceConfig);
+    $cleaner = (new Xssless)->using(new DompurifyServiceConfig);
 
-    expect(fn () => $cleaner->setup())->not->toThrow(Exception::class);
+    expect($cleaner->setup())->toBeTrue();
 });
 
 test('send()', function () {

tests/XsslessTest.php

@@ -6,7 +6,11 @@
 use Medilies\Xssless\Interfaces\ConfigInterface;
 use Medilies\Xssless\Xssless;
 
-it('throws when makeCleaner() with no config', function () {
+// ----------------------------------------------------------------------------
+// makeCleaner()
+// ----------------------------------------------------------------------------
+
+it('throws when makeCleaner() with no interface', function () {
     $cleaner = new Xssless;
 
     $cleaner->using(new class implements ConfigInterface
@@ -20,22 +24,39 @@ public function getClass(): string
     expect(fn () => $cleaner->clean('foo'))->toThrow(XsslessException::class);
 });
 
-it('throws when makeCleaner() with no interface', function () {
+it('throws when makeCleaner() with no config', function () {
     $cleaner = new Xssless;
 
     expect(fn () => $cleaner->clean('foo'))->toThrow(XsslessException::class);
 });
 
-it('throws when start() with CliInterface', function () {
+// ----------------------------------------------------------------------------
+// return gracefully when interface not implemented
+// ----------------------------------------------------------------------------
+
+it('returns null when start() without ServiceInterface', function () {
     $cleaner = new Xssless;
     $cleaner->using(new DompurifyCliConfig);
 
-    expect(fn () => $cleaner->start())->toThrow(XsslessException::class);
+    expect($cleaner->start())->toBeNull();
 });
 
-it('throws when setup() without HasSetupInterface', function () {
+it('returns false when setup() without HasSetupInterface', function () {
     $cleaner = new Xssless;
 
+    class NoSetupDriver implements CliInterface
+    {
+        public function configure(ConfigInterface $config): static
+        {
+            return $this;
+        }
+
+        public function exec(string $html): string
+        {
+            return '';
+        }
+    }
+
     $cleaner->using(new class implements ConfigInterface
     {
         public function getClass(): string
@@ -44,18 +65,5 @@ public function getClass(): string
         }
     });
 
-    expect(fn () => $cleaner->setup())->toThrow(XsslessException::class);
+    expect($cleaner->setup())->toBeFalse();
 });
-
-class NoSetupDriver implements CliInterface
-{
-    public function configure(ConfigInterface $config): static
-    {
-        return $this;
-    }
-
-    public function exec(string $html): string
-    {
-        return '';
-    }
-}