Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace setTimeout(0) by setImmediate() #51

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: replace setTimeout(0) by setImmediate() #51

merged 2 commits into from
Oct 14, 2024

Conversation

murillo128
Copy link
Member

@murillo128 murillo128 commented Oct 11, 2024 •
edited
Loading

setTimout(0) does not execute inmediatelly, but after 1ms, so replacing this by setImmediate()

@murillo128 murillo128 changed the title fix: replace setTimeout(0) by setInmediate() fix: replace setTimeout(0) by setImmediate() Oct 11, 2024
bcostdolby
bcostdolby approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@bcostdolby bcostdolby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@murillo128 murillo128 merged commit b3b5321 into master Oct 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcostdolby bcostdolby bcostdolby approved these changes

@mildsunrise mildsunrise Awaiting requested review from mildsunrise

@harryz2000 harryz2000 Awaiting requested review from harryz2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murillo128 @bcostdolby