Split custom Medplum search parameter definitions into separate file #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiller
added
the
fhir-datastore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codyebberson
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Nice, this is a good change.
If you grep for readJson('fhir/r4/search-parameters.json'), there are quite a few places in the code base where we would need to add search-parameters-medplum.json too. Probably not all of the tests, but we should add them to the packages/generator/src/ files (docs.ts, migrate.ts, searchparams.ts, storybook.ts).
| @@ -250,11 +250,7 @@ export function indexSearchParameterBundle(bundle: Bundle<SearchParameter>): voi | |||
| * @see {@link IndexedStructureDefinition} for more details on indexed StructureDefinitions. | |||
| */ | |||
| export function indexSearchParameter(searchParam: SearchParameter): void { | |||
| if (!searchParam.base) { | |||
There was a problem hiding this comment.
Why this change? If base is undefined, then the function is a no-op, yeah?
There was a problem hiding this comment.
I kept it as a no-op, just streamlined the undefined check so it would instead iterate over an empty array
| for (const entry of searchParams.entry as BundleEntry<SearchParameter>[]) { | ||
| indexSearchParameter(entry.resource as SearchParameter); | ||
| } | ||
| indexSearchParameterBundle(readJson('fhir/r4/search-parameters.json') as Bundle<SearchParameter>); |
| @@ -20,11 +17,6 @@ export async function main(configName: string): Promise<void> { | |||
|
|
|||
| const config = await loadConfig(configName); | |||
|
|
|||
| // Preload the schema | |||
There was a problem hiding this comment.
Oy, we were double loading the schema? 🤦♂️ Nice catch.
IIRC, we did intentionally load the schema before initializing express, to the case where we lazy load the schema inside an HTTP request. Maybe we were doing that anyway (sigh 🤦♂️), but I think the theory still holds? So might be worth adding getStructureDefinitions() here?
|
Kudos, SonarCloud Quality Gate passed! |
codyebberson
approved these changes
Jun 27, 2023
Merged
codyebberson
added a commit
that referenced
this pull request
Jun 30, 2023
Update client-cloudwatch-logs manual mock to use aws-sdk-client-mock (#2342) Log resource for validator latency warning (#2338) Minor tweaks to aws init tool and docs (#2340) Allow contentReference elements to override cardinality rules (#2339) Fixes #2315 - allow bot success without return value (#2336) Fix app env vars in publish job (#2335) Fixes #2310 - CLI rest with --fhir-url-path (#2313) Unify all of the sleep helper functions (#2331) Increase Fargate health check grace period (#2330) Remove PWA and service worker (#2329) Updating subscription documentation to reflect behavior when resources are deleted (#2328) Add app to publish.sh (#2326) Fixes #2306 - remove console.log from export tests due to race conditions (#2322) Fixed landing page for storybook (#2323) Bring back sourcemaps (#2309) Split custom Medplum search parameter definitions into separate file (#2178) Poll status follow Location header (#2307) Copy .env.defaults to .env if not exists (#2308) Allow extra URL path content with Bot execute (#2305) Fixes #2182- All Patient Export (#2293) Strict validation of property cardinality (#2300) Request from ACN (#2299) Fixed CLI shebang (#2301) ESBuild (#2298) Add logs and parity tests for new validator (#2291) Fixes #2277 - Updated access policies docs (#2292) Add non-null requirements to values in GraphQL array types (#2290) Validating Fixed and Pattern Values (#2288) Fixes #2195 - updated cdk init docs (#2289)
codyebberson
added a commit
that referenced
this pull request
Jul 1, 2023
Update client-cloudwatch-logs manual mock to use aws-sdk-client-mock (#2342) Log resource for validator latency warning (#2338) Minor tweaks to aws init tool and docs (#2340) Allow contentReference elements to override cardinality rules (#2339) Fixes #2315 - allow bot success without return value (#2336) Fix app env vars in publish job (#2335) Fixes #2310 - CLI rest with --fhir-url-path (#2313) Unify all of the sleep helper functions (#2331) Increase Fargate health check grace period (#2330) Remove PWA and service worker (#2329) Updating subscription documentation to reflect behavior when resources are deleted (#2328) Add app to publish.sh (#2326) Fixes #2306 - remove console.log from export tests due to race conditions (#2322) Fixed landing page for storybook (#2323) Bring back sourcemaps (#2309) Split custom Medplum search parameter definitions into separate file (#2178) Poll status follow Location header (#2307) Copy .env.defaults to .env if not exists (#2308) Allow extra URL path content with Bot execute (#2305) Fixes #2182- All Patient Export (#2293) Strict validation of property cardinality (#2300) Request from ACN (#2299) Fixed CLI shebang (#2301) ESBuild (#2298) Add logs and parity tests for new validator (#2291) Fixes #2277 - Updated access policies docs (#2292) Add non-null requirements to values in GraphQL array types (#2290) Validating Fixed and Pattern Values (#2288) Fixes #2195 - updated cdk init docs (#2289)
|
Related:#2006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.