This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Feat: product filtering #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…admin into feat/product-filtering
olivermrbl
suggested changes
Oct 8, 2021
There was a problem hiding this comment.
A couple of changes to the UI and one fix to how we fetch tag-usage.
We are currently fetching tag-usage quite a lot. Both on initial load and everytime we click a button. We should limit this to a single call upon opening the products overview.
See attached image for reference:
Did you get a chance to look at these as well? @pKorsholm |
|
I have addressed your comments @olivermrbl 😄 |
fPolic
pushed a commit
that referenced
this pull request
Mar 1, 2022
* hotfix: Show variants on new product (#108) * filter dropdown * tags working * ui update for dropdown * ui adjust * pr adjust * filter dropdown * tags working * ui update for dropdown * ui adjust * pr adjust * tags by id * dont fail if products dont exist * fixed offsets and pagination * review updates * fetch tags only when tags are selected as filters * make tags a filter object * null check for tags * filtering nulls * removed comments * checkpoint * checkpoint * working until every tag is deleted * tooltip working * remove console.log Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com> Co-authored-by: olivermrbl <oliver@mrbltech.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How