Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Feat: Unified search bar #126

Merged
merged 16 commits into from
Oct 20, 2021
Merged

Feat: Unified search bar #126

merged 16 commits into from
Oct 20, 2021

Conversation

sebastiannicolajsen
Copy link
Contributor

What

  • Implement a fixed top bar that allows the user to search within the domain of their current location (i.e. orders in the orders page, products in the products page, customers in the customer page, discounts in the discount page, and gift cards in the gift card page).
  • Allow the users to also log out using this bar.

Why

  • It unifies the look, and the option to log out what currently missing.

How

  • Implement an interface context that allows each domain to submit their own search handlers to the top bar.
  • Utilise the auth session, and update the logout part of the API service to call the newly added delete session found in this PR to Medusajs

@sebastiannicolajsen sebastiannicolajsen changed the base branch from master to develop October 6, 2021 15:49
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.. A couple of things. It does not seem to apply our "tab filters" with the search query.
It work seamlessly, when searching -> adding a filter from the dropdown.
But does not work, when search -> adding a tab filter

Additonally, the search bar should be disabled or removed from the settings page.

@olivermrbl olivermrbl merged commit 0da1411 into develop Oct 20, 2021
@olivermrbl olivermrbl deleted the feat/global-search branch October 20, 2021 11:47
fPolic pushed a commit that referenced this pull request Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants