This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Hide canceled swaps from payment sum #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivermrbl
approved these changes
Jan 2, 2022
fPolic
pushed a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my solution for the issue #195
In the past, when we consulted the details of an order
When we checked the payment overview
In the sum, those swaps that were canceled were considered. This should not be like that. My solution was to add a filter to exclude those swaps canceled when we make the map for the sum.
Please let me know if there is anything I can improve :)