fix(medusa): Legacy total service to accept custom items

medusajs · Jan 13, 2023 · 0487a16 · 0487a16
1 parent 9dbccd9
commit 0487a16
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/medusa/src/services/totals.ts b/packages/medusa/src/services/totals.ts
@@ -840,7 +840,7 @@ class TotalsService extends TransactionBaseService {
          * items we have to get the line items from the tax provider.
          */
         if (options.use_tax_lines || isOrder(cartOrOrder)) {
-          if (typeof lineItem.tax_lines === "undefined") {
+          if (!isDefined(lineItem.tax_lines) && lineItem.variant_id) {
             throw new MedusaError(
               MedusaError.Types.UNEXPECTED_STATE,
               "Tax Lines must be joined on items to calculate taxes"
@@ -850,7 +850,7 @@ class TotalsService extends TransactionBaseService {
           taxLines = lineItem.tax_lines
         } else {
           if (lineItem.is_return) {
-            if (typeof lineItem.tax_lines === "undefined") {
+            if (!isDefined(lineItem.tax_lines) && lineItem.variant_id) {
               throw new MedusaError(
                 MedusaError.Types.UNEXPECTED_STATE,
                 "Return Line Items must join tax lines"