chore(local-file): throw error if file exist (#10087)

medusajs · Nov 14, 2024 · 06ce16c · 06ce16c
1 parent 273960f
commit 06ce16c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/rich-pumpkins-lie.md b/.changeset/rich-pumpkins-lie.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/file-local": patch
+---
+
+Throw error from local file provider
diff --git a/packages/modules/providers/file-local/src/services/local-file.ts b/packages/modules/providers/file-local/src/services/local-file.ts
@@ -71,10 +71,13 @@ export class LocalFileService extends AbstractFileProviderService {
 
     const filePath = this.getUploadFilePath(baseDir, file.fileKey)
     try {
-      await fs.access(filePath, fs.constants.F_OK)
+      await fs.access(filePath, fs.constants.W_OK)
       await fs.unlink(filePath)
     } catch (e) {
-      // The file does not exist, so it's a noop.
+      // The file does not exist, we don't do anything
+      if (e.code !== "ENOENT") {
+        throw e
+      }
     }
 
     return