address feedback

medusajs · Jan 16, 2024 · 2f51e82 · 2f51e82
1 parent 011aa91
commit 2f51e82
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/packages/cart/integration-tests/__tests__/services/cart-module/index.spec.ts b/packages/cart/integration-tests/__tests__/services/cart-module/index.spec.ts
@@ -476,7 +476,7 @@ describe("Cart Module Service", () => {
       expect(updatedItem.title).toBe("test2")
     })
 
-    it.only("should update line items in carts succesfully with multi-selector approach", async () => {
+    it("should update line items in carts succesfully with multi-selector approach", async () => {
       const [createdCart] = await service.create([
         {
           currency_code: "eur",

diff --git a/packages/cart/src/models/line-item.ts b/packages/cart/src/models/line-item.ts
@@ -22,6 +22,7 @@ type OptionalLineItemProps =
   | "is_tax_inclusive"
   | "compare_at_unit_price"
   | "requires_shipping"
+  | "cart"
   | DAL.EntityDateColumns
 
 @Entity({ tableName: "cart_line_item" })
@@ -32,14 +33,14 @@ export default class LineItem {
   id: string
 
   @Property({ columnType: "text" })
-  cart_id!: string
+  cart_id: string
 
   @ManyToOne(() => Cart, {
     onDelete: "cascade",
     index: "IDX_line_item_cart_id",
     nullable: true,
   })
-  cart?: Cart
+  cart?: Cart | null
 
   @Property({ columnType: "text" })
   title: string

diff --git a/packages/cart/src/services/cart-module.ts b/packages/cart/src/services/cart-module.ts
@@ -345,11 +345,10 @@ export default class CartModuleService implements ICartModuleService {
       | string
       | CartTypes.UpdateLineItemWithSelectorDTO[]
       | Partial<CartTypes.CartLineItemDTO>,
-      // @MedusaContext()
-    dataOrSharedContext?:
+    dataOrSharedContext:
       | CartTypes.UpdateLineItemDTO
       | Partial<CartTypes.UpdateLineItemDTO>
-      | Context,
+      | Context = {},
     @MedusaContext()
     sharedContext: Context = {}
   ): Promise<CartTypes.CartLineItemDTO[] | CartTypes.CartLineItemDTO> {
@@ -410,7 +409,6 @@ export default class CartModuleService implements ICartModuleService {
     updates: CartTypes.UpdateLineItemWithSelectorDTO[],
     @MedusaContext() sharedContext: Context = {}
   ): Promise<LineItem[]> {
-    console.log("Context in method: ", sharedContext)
     let toUpdate: UpdateLineItemDTO[] = []
     for (const { selector, data } of updates) {
       const items = await this.listLineItems({ ...selector }, {}, sharedContext)

diff --git a/packages/cart/src/types/line-item.ts b/packages/cart/src/types/line-item.ts
@@ -30,6 +30,8 @@ export interface CreateLineItemDTO extends PartialUpsertLineItemDTO {
   cart_id: string
 }
 
-export interface UpdateLineItemDTO extends PartialUpsertLineItemDTO {
+export interface UpdateLineItemDTO
+  extends PartialUpsertLineItemDTO,
+    Partial<CreateLineItemDTO> {
   id: string
 }
diff --git a/packages/types/src/cart/common.ts b/packages/types/src/cart/common.ts
@@ -341,7 +341,7 @@ export interface CartLineItemDTO {
    *
    * @expandable
    */
-  cart?: CartDTO
+  cart: CartDTO
   /**
    * The ID of the associated cart.
    */