create private onApplicationStart method

medusajs · Jan 22, 2024 · b57fde1 · b57fde1
1 parent 6bd70d9
commit b57fde1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/authentication/src/providers/username-password.ts b/packages/authentication/src/providers/username-password.ts
@@ -24,14 +24,14 @@ class UsernamePasswordProvider extends AbstractAuthenticationModuleProvider {
   ): Promise<AuthenticationResponse> {
     const { email, password } = userData.body
 
-    if (isString(password)) {
+    if (!password || !isString(password)) {
       return {
         success: false,
         error: "Password should be a string",
       }
     }
 
-    if (isString(email)) {
+    if (!email || !isString(email)) {
       return {
         success: false,
         error: "Email should be a string",

diff --git a/packages/authentication/src/services/authentication-module.ts b/packages/authentication/src/services/authentication-module.ts
@@ -48,10 +48,9 @@ export default class AuthenticationModuleService<
   }
 
   __hooks = {
-    onApplicationStart: this.createProvidersOnLoad,
+    onApplicationStart: async () => await this.createProvidersOnLoad(),
   }
 
-
   protected __container__: MedusaContainer
   protected baseRepository_: DAL.RepositoryService