Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa, types): filter product by external_id #10010

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Nov 11, 2024

What

  • fix FilterableProductProps type
  • allow passing external_id filter

FIXES CMRC-667

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:39am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am
api-reference-v2 ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am
docs-ui ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am
docs-v2 ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am
medusa-docs ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am
resources-docs ⬜️ Ignored (Inspect) Nov 11, 2024 9:39am

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: f9f7736

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl merged commit fb05ca2 into develop Nov 11, 2024
24 checks passed
@olivermrbl olivermrbl deleted the fix/product-external-id-filter branch November 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants