Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: object notation in queryparams #1002

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Feat: object notation in queryparams #1002

merged 3 commits into from
Feb 1, 2022

Conversation

pKorsholm
Copy link
Contributor

What

  • update buildquery to include general objects and not only date comparison operators

How

  • include defaultcase in buildquery with objects:
  default: 
    acc[key] = value
    break
  • typeorm supports nested object notation in queries like this, and allows us to use notation like this: /admin/discounts?rule[type]=fixed to query discounts with rules where the type is fixed

@pKorsholm pKorsholm requested a review from a team as a code owner January 19, 2022 11:23
@pKorsholm pKorsholm mentioned this pull request Jan 19, 2022
Merged
olivermrbl
olivermrbl approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srindom srindom merged commit 7fcdac5 into develop Feb 1, 2022
SGFGOV pushed a commit to SGFGOV/medusa that referenced this pull request Apr 19, 2022
@pKorsholm
Feat: object notation in queryparams (medusajs#1002)
c047eca 
* add object notation for queryparams

* test rule.type query params in list-discount

* pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pKorsholm @olivermrbl @srindom