Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): Fix date usage accross workflows #10100

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix(core-flows): Fix date usage accross workflows #10100

merged 3 commits into from
Nov 14, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 14, 2024 •
edited
Loading

FIXES CMRC-691

What
Date is something that get executed, since workflows are meant to compose the definition of what will be executed, the date where always having the same value as they was executed once during composition.
Instead wrap those into transformer that will be executed when needed and fix the Date issues

@adrien2p adrien2p marked this pull request as ready for review November 14, 2024 13:17
@adrien2p adrien2p requested a review from a team as a code owner November 14, 2024 13:17
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 2:47pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 14, 2024 2:47pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 2:47pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 2:47pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 2:47pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 2:47pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 2:47pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dfeb693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p
Copy link
Member Author

cc @frane @carlos-r-l-rodrigues

fPolic
fPolic approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 2e5fd9f into develop Nov 14, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/workflows-date-usage branch November 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@fPolic fPolic fPolic approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @fPolic @carlos-r-l-rodrigues