feat(product,dashboard): Allow re-ordering images #10187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edusa into feat/image-rank-field
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: a166fa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
olivermrbl
approved these changes
Nov 21, 2024
|
@adrien2p, any chance you could glance over the BE in this PR? |
Yes for sure, i can have a look tomorrow morning 🙏 |
adrien2p
approved these changes
Nov 22, 2024
srindom
reviewed
Nov 22, 2024
olivermrbl
reviewed
Nov 22, 2024
…om/medusajs/medusa into feat/image-rank-field-many-to-one
adrien2p
reviewed
Nov 22, 2024
| @@ -52,7 +52,7 @@ export interface SoftDeletableEntity extends BaseEntity { | |||
| /** | |||
| * Temporary type fixing to allow any level of orders until we get to properly clean all the types | |||
| */ | |||
| type FindConfigOrder = { [Key: string]: "ASC" | "DESC" | FindConfigOrder } | |||
| export type FindConfigOrder = { [Key: string]: "ASC" | "DESC" | FindConfigOrder } | |||
There was a problem hiding this comment.
export type FindConfigOrder = { [Key: string]: "ASC" | "DESC" | string & {} | FindConfigOrder }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
product-imagespivot table is migrated.ProductImage.rankfield, the field is treated as readonly, and does not allow the user to set it directly. It is instead inferred by the index of an image in the product payload, e.g.images: [{ url: "./funny-cat.jpg" }, { url: "./funny-dog.jpg" }]is saved as[{ url: "./funny-cat.jpg", rank: 0 }, { url: "./funny-dog.jpg", rank: 1 }].Resolves CMRC-723, CMRC-724, CMRC-725
CLOSES #10128