fix(): Deleted default sales channel should be prevented

[adrien2p]

FIXES CMRC-722

What

• It should not be allowed to delete a default sales channel
• The admin does not allow to delete a sales channel use as the default for the store

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api-reference	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Dec 5, 2024 4:03pm
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 5, 2024 4:03pm

5 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference-v2	⬜️ Ignored (Inspect)	Visit Preview		Dec 5, 2024 4:03pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Dec 5, 2024 4:03pm
docs-v2	⬜️ Ignored (Inspect)	Visit Preview		Dec 5, 2024 4:03pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 5, 2024 4:03pm
resources-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 5, 2024 4:03pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 965e6a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages

Name	Type
@medusajs/core-flows	Patch
@medusajs/types	Patch
@medusajs/dashboard	Patch
integration-tests-http	Patch
@medusajs/admin-bundler	Patch
@medusajs/medusa	Patch
@medusajs/test-utils	Patch
@medusajs/api-key	Patch
@medusajs/auth	Patch
@medusajs/cache-inmemory	Patch
@medusajs/cache-redis	Patch
@medusajs/cart	Patch
@medusajs/currency	Patch
@medusajs/customer	Patch
@medusajs/event-bus-local	Patch
@medusajs/event-bus-redis	Patch
@medusajs/file	Patch
@medusajs/fulfillment	Patch
@medusajs/index	Patch
@medusajs/inventory	Patch
@medusajs/link-modules	Patch
@medusajs/locking	Patch
@medusajs/notification	Patch
@medusajs/order	Patch
@medusajs/payment	Patch
@medusajs/pricing	Patch
@medusajs/product	Patch
@medusajs/promotion	Patch
@medusajs/region	Patch
@medusajs/sales-channel	Patch
@medusajs/stock-location	Patch
@medusajs/store	Patch
@medusajs/tax	Patch
@medusajs/user	Patch
@medusajs/workflow-engine-inmemory	Patch
@medusajs/workflow-engine-redis	Patch
@medusajs/auth-emailpass	Patch
@medusajs/auth-github	Patch
@medusajs/auth-google	Patch
@medusajs/file-local	Patch
@medusajs/file-s3	Patch
@medusajs/fulfillment-manual	Patch
@medusajs/locking-postgres	Patch
@medusajs/locking-redis	Patch
@medusajs/notification-local	Patch
@medusajs/notification-sendgrid	Patch
@medusajs/payment-stripe	Patch
@medusajs/framework	Patch
@medusajs/js-sdk	Patch
@medusajs/modules-sdk	Patch
@medusajs/orchestration	Patch
@medusajs/utils	Patch
@medusajs/workflows-sdk	Patch
@medusajs/cli	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/oas-github-ci	Patch
@medusajs/telemetry	Patch
@medusajs/admin-sdk	Patch
@medusajs/admin-shared	Patch
@medusajs/admin-vite-plugin	Patch
@medusajs/icons	Patch
@medusajs/toolbox	Patch
@medusajs/ui-preset	Patch
create-medusa-app	Patch
medusa-dev-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[adrien2p]

Add tooltip once this pr is merged

[adrien2p]

@olivermrbl should we do something about this bad boy?

[olivermrbl]

Will have a look later today ✅

[adrien2p]

Will have a look later today ✅

any luck on this? :D

[olivermrbl]

LGTM, will let @kasperkristensen have a look at the admin-related changed :)

[fPolic]

Looks good!

Should we disallow disabling the default channel maybe as well?

[adrien2p]

Looks good!

Should we disallow disabling the default channel maybe as well?

that's a good question, should I add it as part of this pr?

[olivermrbl]

Think we can merge this as is?