Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): enable price list prices for product endpoints #10197

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Nov 21, 2024

what:

  • enables price list prices in product endpoints by:
    • adding auth middleware to endpoints
    • fixing the price context to query customer groups correctly

RESOLVES CMRC-731

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:46am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 21, 2024 11:46am
api-reference-v2 ⬜️ Ignored (Inspect) Nov 21, 2024 11:46am
docs-ui ⬜️ Ignored (Inspect) Nov 21, 2024 11:46am
docs-v2 ⬜️ Ignored (Inspect) Nov 21, 2024 11:46am
medusa-docs ⬜️ Ignored (Inspect) Nov 21, 2024 11:46am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 11:46am

@riqwan riqwan requested a review from a team as a code owner November 21, 2024 11:46
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 0c818c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@docloulou
Copy link
Contributor

great, thanks.
BTW, you can close #9825 but can you check my comment : #9825 (comment)

Many thanks

@riqwan
Copy link
Contributor Author

riqwan commented Nov 21, 2024

Thanks @docloulou, will open a separate PR for that!

@riqwan riqwan merged commit d91da7b into develop Nov 21, 2024
24 checks passed
@riqwan riqwan deleted the fix/price-list-prices branch November 21, 2024 13:09
@sergiocampama
Copy link
Contributor

was just banging my head against this this morning, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants