Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Correct Spain provinces in country-states.ts #10264

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

anthid
Copy link
Contributor

@anthid anthid commented Nov 25, 2024

Issues Addressed:

  • Missing provinces (e.g., Ceuta, Melilla).
  • Incorrect inclusion of states as provinces (e.g., Andalucía).
  • Inclusion of a province from another country (e.g., Nouvelle-Calédonie).

Solution:

This update provides an accurate list of Spain's provinces based on the ISO 3166-2 standard. Reference: ISO 3166-2:ES - Provincias.

Issues Addressed:

- Missing provinces (e.g., Ceuta, Melilla).
- Incorrect inclusion of states as provinces (e.g., Andalucía).
- Inclusion of a province from another country (e.g., Nouvelle-Calédonie).

Solution:

This update provides an accurate list of Spain's provinces based on the ISO 3166-2 standard.  
Reference: [ISO 3166-2:ES - Provincias](https://es.wikipedia.org/wiki/ISO_3166-2:ES#Provincias).
@anthid anthid requested a review from a team as a code owner November 25, 2024 14:15
Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 320c84c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 25, 2024

@anthid is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@anthid anthid changed the title fix: Correct Spain provinces in country-states.ts fix(dashboard): Correct Spain provinces in country-states.ts Nov 25, 2024
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @anthid

@kodiakhq kodiakhq bot merged commit e04c9cf into medusajs:develop Nov 27, 2024
15 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants