refactor: migrate pricing entities to DML models #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
thetutlage
commented
Nov 29, 2024
packages/modules/pricing/integration-tests/__tests__/services/pricing-module/price-list.spec.ts
Show resolved
Hide resolved
thetutlage
commented
Nov 29, 2024
packages/modules/pricing/integration-tests/__tests__/services/pricing-module/price-list.spec.ts
Show resolved
Hide resolved
thetutlage
commented
Nov 29, 2024
packages/modules/pricing/integration-tests/__tests__/services/pricing-module/price-list.spec.ts
Show resolved
Hide resolved
thetutlage
commented
Nov 29, 2024
thetutlage
commented
Nov 29, 2024
olivermrbl
approved these changes
Dec 2, 2024
| @@ -40,7 +40,7 @@ const createPriceLists = async ( | |||
| rules: object = defaultRules, | |||
| prices = defaultPriceListPrices | |||
| ) => { | |||
| return await service.createPriceLists([ | |||
| return service.createPriceLists([ | |||
There was a problem hiding this comment.
Nope. By mistake, but it shouldn't change the flow or the behavior of the code. However, happy to revert it back
| @@ -1,6 +1,6 @@ | |||
| import { Migration } from "@mikro-orm/migrations" | |||
|
|
|||
| export class Migration20241127223829 extends Migration { | |||
| export class Migration20241129094116 extends Migration { | |||
There was a problem hiding this comment.
thought: We probably shouldn't rename migrations, as it would otherwise be re-applied no?
hirotaka
pushed a commit
to hirotaka/medusa
that referenced
this pull request
Dec 7, 2024
Fixes: FRMW-2810 ## Breaking changes There is only one breaking change - The `min_quantity` and `max_quantity` properties are now consistently typed as numbers. Earlier, it was [typed as numbers](https://github.com/medusajs/medusa/blob/develop/integration-tests/http/__tests__/price-list/admin/price-list.spec.ts#L68-L69) in some API responses and as [string in others](https://github.com/medusajs/medusa/blob/develop/integration-tests/http/__tests__/price-list/admin/price-list.spec.ts#L186-L187). I did not go to the bottom of this inconsistency, but the tests reveals them. Co-authored-by: Adrien de Peretti <25098370+adrien2p@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FRMW-2810
Breaking changes
There is only one breaking change
min_quantityandmax_quantityproperties are now consistently typed as numbers. Earlier, it was typed as numbers in some API responses and as string in others. I did not go to the bottom of this inconsistency, but the tests reveals them.