Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use the correct defaults for the invite token expiry #10344

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: Use the correct defaults for the invite token expiry #10344

merged 1 commit into from
Nov 28, 2024

Conversation

sradevski
Copy link
Member

FIXES #10342

@sradevski sradevski requested a review from a team as a code owner November 28, 2024 10:15
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:55am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:55am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:55am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:55am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:55am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:55am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:55am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0a45676

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sradevski sradevski force-pushed the fix/use-correct-default-token-expirt branch from c367d21 to f71fd4d Compare November 28, 2024 10:16
@sradevski sradevski mentioned this pull request Nov 28, 2024
Closed
olivermrbl
olivermrbl approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge whenever

@sradevski sradevski force-pushed the fix/use-correct-default-token-expirt branch from f71fd4d to 75d060c Compare November 28, 2024 10:49
@sradevski sradevski force-pushed the fix/use-correct-default-token-expirt branch from 75d060c to 0a45676 Compare November 28, 2024 10:50
@sradevski sradevski merged commit f7279f1 into develop Nov 28, 2024
23 checks passed
@sradevski sradevski deleted the fix/use-correct-default-token-expirt branch November 28, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Invite JWT Does Not Expire After 24 Hours as Expected
2 participants
@sradevski @olivermrbl