Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Migrate auth module to DML #10387

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat(auth): Migrate auth module to DML #10387

merged 3 commits into from
Dec 2, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Dec 2, 2024

RESOLVES FRMW-2816
What
Migrate the auth module to DML

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:10am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 2, 2024 10:10am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:10am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:10am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:10am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:10am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:10am

@adrien2p adrien2p marked this pull request as ready for review December 2, 2024 10:06
@adrien2p adrien2p requested a review from a team as a code owner December 2, 2024 10:06
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 1adca8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/auth Minor
integration-tests-http Patch
@medusajs/medusa Minor
@medusajs/test-utils Minor
@medusajs/api-key Minor
@medusajs/cache-inmemory Minor
@medusajs/cache-redis Minor
@medusajs/cart Minor
@medusajs/currency Minor
@medusajs/customer Minor
@medusajs/event-bus-local Minor
@medusajs/event-bus-redis Minor
@medusajs/file Minor
@medusajs/fulfillment Minor
@medusajs/index Minor
@medusajs/inventory Minor
@medusajs/link-modules Minor
@medusajs/locking Minor
@medusajs/notification Minor
@medusajs/order Minor
@medusajs/payment Minor
@medusajs/pricing Minor
@medusajs/product Minor
@medusajs/promotion Minor
@medusajs/region Minor
@medusajs/sales-channel Minor
@medusajs/stock-location Minor
@medusajs/store Minor
@medusajs/tax Minor
@medusajs/user Minor
@medusajs/workflow-engine-inmemory Minor
@medusajs/workflow-engine-redis Minor
@medusajs/auth-emailpass Minor
@medusajs/auth-github Minor
@medusajs/auth-google Minor
@medusajs/file-local Minor
@medusajs/file-s3 Minor
@medusajs/fulfillment-manual Minor
@medusajs/locking-postgres Minor
@medusajs/locking-redis Minor
@medusajs/notification-local Minor
@medusajs/notification-sendgrid Minor
@medusajs/payment-stripe Minor
@medusajs/core-flows Minor
@medusajs/framework Minor
@medusajs/js-sdk Minor
@medusajs/modules-sdk Minor
@medusajs/orchestration Minor
@medusajs/types Minor
@medusajs/utils Minor
@medusajs/workflows-sdk Minor
@medusajs/cli Minor
@medusajs/medusa-oas-cli Minor
@medusajs/oas-github-ci Minor
@medusajs/telemetry Minor
@medusajs/admin-bundler Minor
@medusajs/admin-sdk Minor
@medusajs/admin-shared Minor
@medusajs/admin-vite-plugin Minor
@medusajs/dashboard Minor
@medusajs/icons Minor
@medusajs/toolbox Minor
@medusajs/ui-preset Minor
create-medusa-app Minor
medusa-dev-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +5 to +17
this.addSql(
'alter table if exists "auth_identity" add column if not exists "deleted_at" timestamptz null;'
)
this.addSql(
'CREATE INDEX IF NOT EXISTS "IDX_auth_identity_deleted_at" ON "auth_identity" (deleted_at) WHERE deleted_at IS NULL;'
)

this.addSql(
'alter table if exists "provider_identity" add column if not exists "deleted_at" timestamptz null;'
)
this.addSql(
'CREATE INDEX IF NOT EXISTS "IDX_provider_identity_deleted_at" ON "provider_identity" (deleted_at) WHERE deleted_at IS NULL;'
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: The entities were not soft deletable and are now by default, this is why there is this migration.

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! LGTM

@adrien2p adrien2p merged commit 4ef353a into develop Dec 2, 2024
23 checks passed
hirotaka pushed a commit to hirotaka/medusa that referenced this pull request Dec 7, 2024
* feat(auth): Migrate auth module to DML

* Create lazy-eagles-bow.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants