-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom line items #10408
feat: Custom line items #10408
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: cd645db The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.1.0-snapshot-20241203120710 yarn add @medusajs/admin-sdk@2.1.0-snapshot-20241203120710 yarn add @medusajs/admin-shared@2.1.0-snapshot-20241203120710 yarn add @medusajs/admin-vite-plugin@2.1.0-snapshot-20241203120710 yarn add @medusajs/dashboard@2.1.0-snapshot-20241203120710 yarn add create-medusa-app@2.1.0-snapshot-20241203120710 yarn add @medusajs/cli@2.1.0-snapshot-20241203120710 yarn add medusa-dev-cli@2.1.0-snapshot-20241203120710 yarn add @medusajs/medusa-oas-cli@2.1.0-snapshot-20241203120710 yarn add @medusajs/core-flows@2.1.0-snapshot-20241203120710 yarn add @medusajs/framework@2.1.0-snapshot-20241203120710 yarn add @medusajs/js-sdk@2.1.0-snapshot-20241203120710 yarn add @medusajs/modules-sdk@2.1.0-snapshot-20241203120710 yarn add @medusajs/orchestration@2.1.0-snapshot-20241203120710 yarn add @medusajs/types@2.1.0-snapshot-20241203120710 yarn add @medusajs/utils@2.1.0-snapshot-20241203120710 yarn add @medusajs/workflows-sdk@2.1.0-snapshot-20241203120710 yarn add @medusajs/icons@2.1.0-snapshot-20241203120710 yarn add @medusajs/ui-preset@2.1.0-snapshot-20241203120710 yarn add @medusajs/medusa@2.1.0-snapshot-20241203120710 yarn add @medusajs/telemetry@2.1.0-snapshot-20241203120710 yarn add @medusajs/test-utils@2.1.0-snapshot-20241203120710 yarn add @medusajs/api-key@2.1.0-snapshot-20241203120710 yarn add @medusajs/auth@2.1.0-snapshot-20241203120710 yarn add @medusajs/cache-inmemory@2.1.0-snapshot-20241203120710 yarn add @medusajs/cache-redis@2.1.0-snapshot-20241203120710 yarn add @medusajs/cart@2.1.0-snapshot-20241203120710 yarn add @medusajs/currency@2.1.0-snapshot-20241203120710 yarn add @medusajs/customer@2.1.0-snapshot-20241203120710 yarn add @medusajs/event-bus-local@2.1.0-snapshot-20241203120710 yarn add @medusajs/event-bus-redis@2.1.0-snapshot-20241203120710 yarn add @medusajs/file@2.1.0-snapshot-20241203120710 yarn add @medusajs/fulfillment@2.1.0-snapshot-20241203120710 yarn add @medusajs/index@2.1.0-snapshot-20241203120710 yarn add @medusajs/inventory@2.1.0-snapshot-20241203120710 yarn add @medusajs/link-modules@2.1.0-snapshot-20241203120710 yarn add @medusajs/locking@2.1.0-snapshot-20241203120710 yarn add @medusajs/notification@2.1.0-snapshot-20241203120710 yarn add @medusajs/order@2.1.0-snapshot-20241203120710 yarn add @medusajs/payment@2.1.0-snapshot-20241203120710 yarn add @medusajs/pricing@2.1.0-snapshot-20241203120710 yarn add @medusajs/product@2.1.0-snapshot-20241203120710 yarn add @medusajs/promotion@2.1.0-snapshot-20241203120710 yarn add @medusajs/auth-emailpass@2.1.0-snapshot-20241203120710 yarn add @medusajs/auth-github@2.1.0-snapshot-20241203120710 yarn add @medusajs/auth-google@2.1.0-snapshot-20241203120710 yarn add @medusajs/file-local@2.1.0-snapshot-20241203120710 yarn add @medusajs/file-s3@2.1.0-snapshot-20241203120710 yarn add @medusajs/fulfillment-manual@2.1.0-snapshot-20241203120710 yarn add @medusajs/locking-postgres@2.1.0-snapshot-20241203120710 yarn add @medusajs/locking-redis@2.1.0-snapshot-20241203120710 yarn add @medusajs/notification-local@2.1.0-snapshot-20241203120710 yarn add @medusajs/notification-sendgrid@2.1.0-snapshot-20241203120710 yarn add @medusajs/payment-stripe@2.1.0-snapshot-20241203120710 yarn add @medusajs/region@2.1.0-snapshot-20241203120710 yarn add @medusajs/sales-channel@2.1.0-snapshot-20241203120710 yarn add @medusajs/stock-location@2.1.0-snapshot-20241203120710 yarn add @medusajs/store@2.1.0-snapshot-20241203120710 yarn add @medusajs/tax@2.1.0-snapshot-20241203120710 yarn add @medusajs/user@2.1.0-snapshot-20241203120710 yarn add @medusajs/workflow-engine-inmemory@2.1.0-snapshot-20241203120710 yarn add @medusajs/workflow-engine-redis@2.1.0-snapshot-20241203120710
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.1.0-snapshot-20241203132414 yarn add @medusajs/admin-sdk@2.1.0-snapshot-20241203132414 yarn add @medusajs/admin-shared@2.1.0-snapshot-20241203132414 yarn add @medusajs/admin-vite-plugin@2.1.0-snapshot-20241203132414 yarn add @medusajs/dashboard@2.1.0-snapshot-20241203132414 yarn add create-medusa-app@2.1.0-snapshot-20241203132414 yarn add @medusajs/cli@2.1.0-snapshot-20241203132414 yarn add medusa-dev-cli@2.1.0-snapshot-20241203132414 yarn add @medusajs/medusa-oas-cli@2.1.0-snapshot-20241203132414 yarn add @medusajs/core-flows@2.1.0-snapshot-20241203132414 yarn add @medusajs/framework@2.1.0-snapshot-20241203132414 yarn add @medusajs/js-sdk@2.1.0-snapshot-20241203132414 yarn add @medusajs/modules-sdk@2.1.0-snapshot-20241203132414 yarn add @medusajs/orchestration@2.1.0-snapshot-20241203132414 yarn add @medusajs/types@2.1.0-snapshot-20241203132414 yarn add @medusajs/utils@2.1.0-snapshot-20241203132414 yarn add @medusajs/workflows-sdk@2.1.0-snapshot-20241203132414 yarn add @medusajs/icons@2.1.0-snapshot-20241203132414 yarn add @medusajs/ui-preset@2.1.0-snapshot-20241203132414 yarn add @medusajs/medusa@2.1.0-snapshot-20241203132414 yarn add @medusajs/telemetry@2.1.0-snapshot-20241203132414 yarn add @medusajs/test-utils@2.1.0-snapshot-20241203132414 yarn add @medusajs/api-key@2.1.0-snapshot-20241203132414 yarn add @medusajs/auth@2.1.0-snapshot-20241203132414 yarn add @medusajs/cache-inmemory@2.1.0-snapshot-20241203132414 yarn add @medusajs/cache-redis@2.1.0-snapshot-20241203132414 yarn add @medusajs/cart@2.1.0-snapshot-20241203132414 yarn add @medusajs/currency@2.1.0-snapshot-20241203132414 yarn add @medusajs/customer@2.1.0-snapshot-20241203132414 yarn add @medusajs/event-bus-local@2.1.0-snapshot-20241203132414 yarn add @medusajs/event-bus-redis@2.1.0-snapshot-20241203132414 yarn add @medusajs/file@2.1.0-snapshot-20241203132414 yarn add @medusajs/fulfillment@2.1.0-snapshot-20241203132414 yarn add @medusajs/index@2.1.0-snapshot-20241203132414 yarn add @medusajs/inventory@2.1.0-snapshot-20241203132414 yarn add @medusajs/link-modules@2.1.0-snapshot-20241203132414 yarn add @medusajs/locking@2.1.0-snapshot-20241203132414 yarn add @medusajs/notification@2.1.0-snapshot-20241203132414 yarn add @medusajs/order@2.1.0-snapshot-20241203132414 yarn add @medusajs/payment@2.1.0-snapshot-20241203132414 yarn add @medusajs/pricing@2.1.0-snapshot-20241203132414 yarn add @medusajs/product@2.1.0-snapshot-20241203132414 yarn add @medusajs/promotion@2.1.0-snapshot-20241203132414 yarn add @medusajs/auth-emailpass@2.1.0-snapshot-20241203132414 yarn add @medusajs/auth-github@2.1.0-snapshot-20241203132414 yarn add @medusajs/auth-google@2.1.0-snapshot-20241203132414 yarn add @medusajs/file-local@2.1.0-snapshot-20241203132414 yarn add @medusajs/file-s3@2.1.0-snapshot-20241203132414 yarn add @medusajs/fulfillment-manual@2.1.0-snapshot-20241203132414 yarn add @medusajs/locking-postgres@2.1.0-snapshot-20241203132414 yarn add @medusajs/locking-redis@2.1.0-snapshot-20241203132414 yarn add @medusajs/notification-local@2.1.0-snapshot-20241203132414 yarn add @medusajs/notification-sendgrid@2.1.0-snapshot-20241203132414 yarn add @medusajs/payment-stripe@2.1.0-snapshot-20241203132414 yarn add @medusajs/region@2.1.0-snapshot-20241203132414 yarn add @medusajs/sales-channel@2.1.0-snapshot-20241203132414 yarn add @medusajs/stock-location@2.1.0-snapshot-20241203132414 yarn add @medusajs/store@2.1.0-snapshot-20241203132414 yarn add @medusajs/tax@2.1.0-snapshot-20241203132414 yarn add @medusajs/user@2.1.0-snapshot-20241203132414 yarn add @medusajs/workflow-engine-inmemory@2.1.0-snapshot-20241203132414 yarn add @medusajs/workflow-engine-redis@2.1.0-snapshot-20241203132414
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.1.1-snapshot-20241205131915 yarn add @medusajs/admin-sdk@2.1.1-snapshot-20241205131915 yarn add @medusajs/admin-shared@2.1.1-snapshot-20241205131915 yarn add @medusajs/admin-vite-plugin@2.1.1-snapshot-20241205131915 yarn add @medusajs/dashboard@2.1.1-snapshot-20241205131915 yarn add create-medusa-app@2.1.1-snapshot-20241205131915 yarn add @medusajs/cli@2.1.1-snapshot-20241205131915 yarn add medusa-dev-cli@2.1.1-snapshot-20241205131915 yarn add @medusajs/medusa-oas-cli@2.1.1-snapshot-20241205131915 yarn add @medusajs/core-flows@2.1.1-snapshot-20241205131915 yarn add @medusajs/framework@2.1.1-snapshot-20241205131915 yarn add @medusajs/js-sdk@2.1.1-snapshot-20241205131915 yarn add @medusajs/modules-sdk@2.1.1-snapshot-20241205131915 yarn add @medusajs/orchestration@2.1.1-snapshot-20241205131915 yarn add @medusajs/types@2.1.1-snapshot-20241205131915 yarn add @medusajs/utils@2.1.1-snapshot-20241205131915 yarn add @medusajs/workflows-sdk@2.1.1-snapshot-20241205131915 yarn add @medusajs/icons@2.1.1-snapshot-20241205131915 yarn add @medusajs/ui-preset@2.1.1-snapshot-20241205131915 yarn add @medusajs/medusa@2.1.1-snapshot-20241205131915 yarn add @medusajs/telemetry@2.1.1-snapshot-20241205131915 yarn add @medusajs/test-utils@2.1.1-snapshot-20241205131915 yarn add @medusajs/api-key@2.1.1-snapshot-20241205131915 yarn add @medusajs/auth@2.1.1-snapshot-20241205131915 yarn add @medusajs/cache-inmemory@2.1.1-snapshot-20241205131915 yarn add @medusajs/cache-redis@2.1.1-snapshot-20241205131915 yarn add @medusajs/cart@2.1.1-snapshot-20241205131915 yarn add @medusajs/currency@2.1.1-snapshot-20241205131915 yarn add @medusajs/customer@2.1.1-snapshot-20241205131915 yarn add @medusajs/event-bus-local@2.1.1-snapshot-20241205131915 yarn add @medusajs/event-bus-redis@2.1.1-snapshot-20241205131915 yarn add @medusajs/file@2.1.1-snapshot-20241205131915 yarn add @medusajs/fulfillment@2.1.1-snapshot-20241205131915 yarn add @medusajs/index@2.1.1-snapshot-20241205131915 yarn add @medusajs/inventory@2.1.1-snapshot-20241205131915 yarn add @medusajs/link-modules@2.1.1-snapshot-20241205131915 yarn add @medusajs/locking@2.1.1-snapshot-20241205131915 yarn add @medusajs/notification@2.1.1-snapshot-20241205131915 yarn add @medusajs/order@2.1.1-snapshot-20241205131915 yarn add @medusajs/payment@2.1.1-snapshot-20241205131915 yarn add @medusajs/pricing@2.1.1-snapshot-20241205131915 yarn add @medusajs/product@2.1.1-snapshot-20241205131915 yarn add @medusajs/promotion@2.1.1-snapshot-20241205131915 yarn add @medusajs/auth-emailpass@2.1.1-snapshot-20241205131915 yarn add @medusajs/auth-github@2.1.1-snapshot-20241205131915 yarn add @medusajs/auth-google@2.1.1-snapshot-20241205131915 yarn add @medusajs/file-local@2.1.1-snapshot-20241205131915 yarn add @medusajs/file-s3@2.1.1-snapshot-20241205131915 yarn add @medusajs/fulfillment-manual@2.1.1-snapshot-20241205131915 yarn add @medusajs/locking-postgres@2.1.1-snapshot-20241205131915 yarn add @medusajs/locking-redis@2.1.1-snapshot-20241205131915 yarn add @medusajs/notification-local@2.1.1-snapshot-20241205131915 yarn add @medusajs/notification-sendgrid@2.1.1-snapshot-20241205131915 yarn add @medusajs/payment-stripe@2.1.1-snapshot-20241205131915 yarn add @medusajs/region@2.1.1-snapshot-20241205131915 yarn add @medusajs/sales-channel@2.1.1-snapshot-20241205131915 yarn add @medusajs/stock-location@2.1.1-snapshot-20241205131915 yarn add @medusajs/store@2.1.1-snapshot-20241205131915 yarn add @medusajs/tax@2.1.1-snapshot-20241205131915 yarn add @medusajs/user@2.1.1-snapshot-20241205131915 yarn add @medusajs/workflow-engine-inmemory@2.1.1-snapshot-20241205131915 yarn add @medusajs/workflow-engine-redis@2.1.1-snapshot-20241205131915
|
@riqwan, would appreciate if you could also lay your eyes on this PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
packages/modules/cart/src/migrations/Migration20241125130058.ts
Outdated
Show resolved
Hide resolved
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.1.3-snapshot-20241218105855 yarn add @medusajs/admin-sdk@2.1.3-snapshot-20241218105855 yarn add @medusajs/admin-shared@2.1.3-snapshot-20241218105855 yarn add @medusajs/admin-vite-plugin@2.1.3-snapshot-20241218105855 yarn add @medusajs/dashboard@2.1.3-snapshot-20241218105855 yarn add create-medusa-app@2.1.3-snapshot-20241218105855 yarn add @medusajs/cli@2.1.3-snapshot-20241218105855 yarn add medusa-dev-cli@2.1.3-snapshot-20241218105855 yarn add @medusajs/medusa-oas-cli@2.1.3-snapshot-20241218105855 yarn add @medusajs/core-flows@2.1.3-snapshot-20241218105855 yarn add @medusajs/framework@2.1.3-snapshot-20241218105855 yarn add @medusajs/js-sdk@2.1.3-snapshot-20241218105855 yarn add @medusajs/modules-sdk@2.1.3-snapshot-20241218105855 yarn add @medusajs/orchestration@2.1.3-snapshot-20241218105855 yarn add @medusajs/types@2.1.3-snapshot-20241218105855 yarn add @medusajs/utils@2.1.3-snapshot-20241218105855 yarn add @medusajs/workflows-sdk@2.1.3-snapshot-20241218105855 yarn add @medusajs/icons@2.1.3-snapshot-20241218105855 yarn add @medusajs/ui-preset@2.1.3-snapshot-20241218105855 yarn add @medusajs/medusa@2.1.3-snapshot-20241218105855 yarn add @medusajs/telemetry@2.1.3-snapshot-20241218105855 yarn add @medusajs/test-utils@2.1.3-snapshot-20241218105855 yarn add @medusajs/api-key@2.1.3-snapshot-20241218105855 yarn add @medusajs/auth@2.1.3-snapshot-20241218105855 yarn add @medusajs/cache-inmemory@2.1.3-snapshot-20241218105855 yarn add @medusajs/cache-redis@2.1.3-snapshot-20241218105855 yarn add @medusajs/cart@2.1.3-snapshot-20241218105855 yarn add @medusajs/currency@2.1.3-snapshot-20241218105855 yarn add @medusajs/customer@2.1.3-snapshot-20241218105855 yarn add @medusajs/event-bus-local@2.1.3-snapshot-20241218105855 yarn add @medusajs/event-bus-redis@2.1.3-snapshot-20241218105855 yarn add @medusajs/file@2.1.3-snapshot-20241218105855 yarn add @medusajs/fulfillment@2.1.3-snapshot-20241218105855 yarn add @medusajs/index@2.1.3-snapshot-20241218105855 yarn add @medusajs/inventory@2.1.3-snapshot-20241218105855 yarn add @medusajs/link-modules@2.1.3-snapshot-20241218105855 yarn add @medusajs/locking@2.1.3-snapshot-20241218105855 yarn add @medusajs/notification@2.1.3-snapshot-20241218105855 yarn add @medusajs/order@2.1.3-snapshot-20241218105855 yarn add @medusajs/payment@2.1.3-snapshot-20241218105855 yarn add @medusajs/pricing@2.1.3-snapshot-20241218105855 yarn add @medusajs/product@2.1.3-snapshot-20241218105855 yarn add @medusajs/promotion@2.1.3-snapshot-20241218105855 yarn add @medusajs/auth-emailpass@2.1.3-snapshot-20241218105855 yarn add @medusajs/auth-github@2.1.3-snapshot-20241218105855 yarn add @medusajs/auth-google@2.1.3-snapshot-20241218105855 yarn add @medusajs/file-local@2.1.3-snapshot-20241218105855 yarn add @medusajs/file-s3@2.1.3-snapshot-20241218105855 yarn add @medusajs/fulfillment-manual@2.1.3-snapshot-20241218105855 yarn add @medusajs/locking-postgres@2.1.3-snapshot-20241218105855 yarn add @medusajs/locking-redis@2.1.3-snapshot-20241218105855 yarn add @medusajs/notification-local@2.1.3-snapshot-20241218105855 yarn add @medusajs/notification-sendgrid@2.1.3-snapshot-20241218105855 yarn add @medusajs/payment-stripe@2.1.3-snapshot-20241218105855 yarn add @medusajs/region@2.1.3-snapshot-20241218105855 yarn add @medusajs/sales-channel@2.1.3-snapshot-20241218105855 yarn add @medusajs/stock-location@2.1.3-snapshot-20241218105855 yarn add @medusajs/store@2.1.3-snapshot-20241218105855 yarn add @medusajs/tax@2.1.3-snapshot-20241218105855 yarn add @medusajs/user@2.1.3-snapshot-20241218105855 yarn add @medusajs/workflow-engine-inmemory@2.1.3-snapshot-20241218105855 yarn add @medusajs/workflow-engine-redis@2.1.3-snapshot-20241218105855
|
…usa into feat/custom-line-item-price
Adds support for custom line items and line items with a custom price. We had all the pieces to enable this feature, they just needed some adaptation to work as expected for all scenarios.
The changes are primarily around ensuring the correct shape of line items depending on the input in a range of workflows including:
The approach taken in the PR is documented in this RFC and all the scenarios can be found here.