refactor: migrate promotion module #10410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: fdc11a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thetutlage
requested review from
adrien2p,
carlos-r-l-rodrigues and
olivermrbl
and removed request for
christiananese,
fPolic and
kasperkristensen
thetutlage
commented
Dec 4, 2024
...es/modules/promotion/integration-tests/__tests__/services/promotion-module/promotion.spec.ts
Show resolved
Hide resolved
carlos-r-l-rodrigues
approved these changes
Dec 10, 2024
olivermrbl
approved these changes
Dec 10, 2024
...es/modules/promotion/integration-tests/__tests__/services/promotion-module/promotion.spec.ts
Show resolved
Hide resolved
packages/modules/promotion/src/migrations/Migration20241203074045.ts
Outdated
Show resolved
Hide resolved
packages/modules/promotion/src/migrations/Migration20241203074045.ts
Outdated
Show resolved
Hide resolved
thetutlage
commented
Dec 11, 2024
| @@ -16,6 +16,7 @@ export function applyIndexes( | |||
| ) { | |||
| field.indexes.forEach((index) => { | |||
| const providerEntityIdIndexStatement = createPsqlIndexStatementHelper({ | |||
| name: index.name, | |||
There was a problem hiding this comment.
@olivermrbl Because of this, the migration was dropping an existing index and was re-creating it with a different name
This was referenced Dec 11, 2024
Closed
jimrarras
pushed a commit
to jimrarras/medusa
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: FRMW-2822
No breaking changes in this PR. However, migrations should be applied