Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin, js-sdk, types): update order forms #10418

Merged
merged 7 commits into from
Dec 4, 2024
Merged

feat(admin, js-sdk, types): update order forms #10418

merged 7 commits into from
Dec 4, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Dec 3, 2024

What

  • add edit email, shipping and billing address forms
  • add js-sdk methods / hooks / types

CLOSES CMRC-634 CMRC-635 CMRC-636

@fPolic fPolic requested a review from a team as a code owner December 3, 2024 17:26
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:36pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 4, 2024 1:36pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 1:36pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 1:36pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 1:36pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 1:36pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 1:36pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 541f4e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic requested review from olivermrbl and removed request for sgirones and sradevski December 3, 2024 17:26
@fPolic fPolic changed the title feat(admin, js-sdk, types): edit order forms feat(admin, js-sdk, types): update order forms Dec 3, 2024
olivermrbl
olivermrbl approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending @kasperkristensen's review

kasperkristensen
kasperkristensen approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions, but otherwise LGTM!

.../admin/dashboard/src/routes/orders/order-edit-billing-address/order-edit-billing-address.tsx Outdated Show resolved Hide resolved
...rc/routes/orders/order-edit-email/components/edit-order-email-form/edit-order-email-form.tsx Show resolved Hide resolved
...rc/routes/orders/order-edit-email/components/edit-order-email-form/edit-order-email-form.tsx Outdated Show resolved Hide resolved
packages/admin/dashboard/src/routes/orders/order-edit-email/order-edit-email.tsx Outdated Show resolved Hide resolved
...ing-address/components/edit-order-shipping-address-form/edit-order-shipping-address-form.tsx Outdated Show resolved Hide resolved
@olivermrbl olivermrbl merged commit 3407695 into develop Dec 4, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/admin-order-update branch December 4, 2024 13:56
hirotaka pushed a commit to hirotaka/medusa that referenced this pull request Dec 7, 2024
@fPolic @hirotaka
feat(admin, js-sdk, types): update order forms (medusajs#10418)
75dc65a 
* feat: edit shipping, billing and email forms

* feat: timeline history, update change model, update tests

* fix: address comments

* fix: invalidation, translation schema, update label

* fix: old/new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@kasperkristensen kasperkristensen kasperkristensen approved these changes

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @kasperkristensen @olivermrbl