Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow-engine): Migrate to DML #10477

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Dec 6, 2024

RESOLVES FRMW-2832
RESOLVES FRMW-2833

What
Migrate workflow engines to DML. Alos includes and update to the linkable generation which now takes into account id and primary keys to generate the linkable instead of only primary keys

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 1:06pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 6, 2024 1:06pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:06pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:06pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:06pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:06pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:06pm

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: cf7a557

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/utils Patch
integration-tests-http Patch
@medusajs/cli Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, would be nice to apply the provider pattern to the workflow engine (and event bus + cache) at some point, so we can get rid of the duplicated code

@adrien2p
Copy link
Member Author

adrien2p commented Dec 6, 2024

Nice, would be nice to apply the provider pattern to the workflow engine (and event bus + cache) at some point, so we can get rid of the duplicated code

Yes I do agree, but that is another project and breaking changes, so I didn't do it here

@olivermrbl
Copy link
Contributor

but that is another project and breaking changes, so I didn't do it here

💯

@kodiakhq kodiakhq bot merged commit 0a077d4 into develop Dec 6, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/workflow-engin-inmemory-dml branch December 6, 2024 13:23
hirotaka pushed a commit to hirotaka/medusa that referenced this pull request Dec 7, 2024
RESOLVES FRMW-2832
RESOLVES FRMW-2833

**What**
Migrate workflow engines to DML. Alos includes and update to the linkable generation which now takes into account id and primary keys to generate the linkable instead of only primary keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants