Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): add price types for shipping option endpoints #10509

Merged
merged 3 commits into from
Dec 9, 2024
Merged

chore(types): add price types for shipping option endpoints #10509

merged 3 commits into from
Dec 9, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Dec 9, 2024

what:

  • adds missing price types for shipping options

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 1:36pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 1:36pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 1:36pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 1:36pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 1:36pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 1:36pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 1:36pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 25a3e28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review December 9, 2024 13:31
@riqwan riqwan requested a review from a team as a code owner December 9, 2024 13:31
olivermrbl
olivermrbl approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit f8f5d57 into develop Dec 9, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/shipping-changes branch December 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @olivermrbl