feat(medusa,pricing): Cart pricing context with customer group #10579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lists (#10493) *What* * Fixes #10490 * Expands any available customer_id into its customer_group_ids for cart updates that add line items. *Why* * Cart updates from the storefront were overriding any valid price lists that were correctly being shown in the storefront's product pages. *How* * Adds a new workflow step that expands an optional customer_id into the customer_group_ids it belongs to. * Uses this step in the addToCartWorkflow and updateLineItemInCartWorkflow workflows. *Testing* * Using medusa-dev to test on a local backend. * Adds integration tests for the addToCart and updateLineItemInCart workflows. Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 713955b The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Well spotted ;) |
riqwan
force-pushed
the
feat/customer-group-context
branch
from
4d6345f to
554e45c
Compare
|
@riqwan same situation here Order add line item WF |
|
@docloulou thanks, there are 10 different workflows in orders that needs to be updated, but that will come in a different PR. 🤞🏻 |
riqwan
changed the title
olivermrbl
reviewed
Dec 13, 2024
| import { confirmVariantInventoryWorkflow } from "./confirm-variant-inventory" | ||
| import { refreshCartItemsWorkflow } from "./refresh-cart-items" | ||
|
|
||
| const cartFields = cartFieldsForPricingContext.concat(["items.*"]) | ||
|
|
||
| export const updateLineItemInCartWorkflowId = "update-line-item-in-cart" | ||
| /** | ||
| * This workflow updates a cart's line item. | ||
| */ | ||
| export const updateLineItemInCartWorkflow = createWorkflow( |
There was a problem hiding this comment.
note to self: Input type change is a breaking change.
olivermrbl
approved these changes
Dec 16, 2024
adrien2p
approved these changes
Dec 16, 2024
| @@ -0,0 +1,86 @@ | |||
| import { isDefined } from "./is-defined" | |||
|
|
|||
| export function filterObjectByKeys(obj, paths) { | |||
There was a problem hiding this comment.
suggestion: A description and example here would be nice to have
| [key: string]: any | ||
| } | ||
|
|
||
| export function flattenObjectToKeyValuePairs(obj: NestedObject): NestedObject { |
There was a problem hiding this comment.
same suggestion as the previous one
| keys.forEach((key) => { | ||
| const values = arrayObjects | ||
| .map((item) => { | ||
| if (item && typeof item === "object") { |
There was a problem hiding this comment.
suggestion: for those type of check would the util isObject be more convenient?
|
|
||
| if (values.length > 0) { | ||
| const newPath = `${pathStr}.${key}` | ||
| if (values.every((v) => typeof v === "object" && !Array.isArray(v))) { |
There was a problem hiding this comment.
suggestion: should we use isObject?
There was a problem hiding this comment.
@adrien2p sorry, just saw this. Will open a new PR with these changes to get this PR into the release.
|
thanks @riqwan! do you know when a new version might get released with this fix? |
|
@sergiocampama today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
customer_group_idrule is renamedcustomer.groups.idin line with cart shapeThanks to initial contribution from @sergiocampama - #10493
RESOLVES CMRC-745