Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use correct env variable for medusa admin in server mode deployment #10764

Conversation

ranjithkumar8352
Copy link
Contributor

@ranjithkumar8352 ranjithkumar8352 commented Dec 29, 2024

Resolves #10763

Deployment docs mention setting the DISABLE_MEDUSA_ADMIN variable to false correctly in the instructions but the code block with the env variables shows it as true which can be confusing to the readers.

@ranjithkumar8352 ranjithkumar8352 requested a review from a team as a code owner December 29, 2024 17:41
Copy link

changeset-bot bot commented Dec 29, 2024

⚠️ No Changeset found

Latest commit: 66eac74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 29, 2024

@ranjithkumar8352 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@shahednasser shahednasser merged commit 5ca4b0b into medusajs:develop Dec 31, 2024
23 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISABLE_MEDUSA_ADMIN should be false in Server Mode
2 participants