feat(auth-google,auth-github): Allow passing a custom callbackUrl to … #10829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sradevski
requested review from
sgirones,
carlos-r-l-rodrigues and
kasperkristensen
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
sradevski
force-pushed
the
feat/add-support-custom-callback-uri-oauth
branch
from
091b1ed to
3506098
Compare
sradevski
force-pushed
the
feat/add-support-custom-callback-uri-oauth
branch
from
3506098 to
f339ff2
Compare
sradevski
commented
Jan 6, 2025
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.1.4-snapshot-20250106093301yarn add @medusajs/admin-sdk@2.1.4-snapshot-20250106093301yarn add @medusajs/admin-shared@2.1.4-snapshot-20250106093301yarn add @medusajs/admin-vite-plugin@2.1.4-snapshot-20250106093301yarn add @medusajs/dashboard@2.1.4-snapshot-20250106093301yarn add create-medusa-app@2.1.4-snapshot-20250106093301yarn add @medusajs/cli@2.1.4-snapshot-20250106093301yarn add medusa-dev-cli@2.1.4-snapshot-20250106093301yarn add @medusajs/medusa-oas-cli@2.1.4-snapshot-20250106093301yarn add @medusajs/core-flows@2.1.4-snapshot-20250106093301yarn add @medusajs/framework@2.1.4-snapshot-20250106093301yarn add @medusajs/js-sdk@2.1.4-snapshot-20250106093301yarn add @medusajs/modules-sdk@2.1.4-snapshot-20250106093301yarn add @medusajs/orchestration@2.1.4-snapshot-20250106093301yarn add @medusajs/types@2.1.4-snapshot-20250106093301yarn add @medusajs/utils@2.1.4-snapshot-20250106093301yarn add @medusajs/workflows-sdk@2.1.4-snapshot-20250106093301yarn add @medusajs/icons@2.1.4-snapshot-20250106093301yarn add @medusajs/ui@4.0.3-snapshot-20250106093301yarn add @medusajs/ui-preset@2.1.4-snapshot-20250106093301yarn add @medusajs/medusa@2.1.4-snapshot-20250106093301yarn add @medusajs/telemetry@2.1.4-snapshot-20250106093301yarn add @medusajs/test-utils@2.1.4-snapshot-20250106093301yarn add @medusajs/api-key@2.1.4-snapshot-20250106093301yarn add @medusajs/auth@2.1.4-snapshot-20250106093301yarn add @medusajs/cache-inmemory@2.1.4-snapshot-20250106093301yarn add @medusajs/cache-redis@2.1.4-snapshot-20250106093301yarn add @medusajs/cart@2.1.4-snapshot-20250106093301yarn add @medusajs/currency@2.1.4-snapshot-20250106093301yarn add @medusajs/customer@2.1.4-snapshot-20250106093301yarn add @medusajs/event-bus-local@2.1.4-snapshot-20250106093301yarn add @medusajs/event-bus-redis@2.1.4-snapshot-20250106093301yarn add @medusajs/file@2.1.4-snapshot-20250106093301yarn add @medusajs/fulfillment@2.1.4-snapshot-20250106093301yarn add @medusajs/index@2.1.4-snapshot-20250106093301yarn add @medusajs/inventory@2.1.4-snapshot-20250106093301yarn add @medusajs/link-modules@2.1.4-snapshot-20250106093301yarn add @medusajs/locking@2.1.4-snapshot-20250106093301yarn add @medusajs/notification@2.1.4-snapshot-20250106093301yarn add @medusajs/order@2.1.4-snapshot-20250106093301yarn add @medusajs/payment@2.1.4-snapshot-20250106093301yarn add @medusajs/pricing@2.1.4-snapshot-20250106093301yarn add @medusajs/product@2.1.4-snapshot-20250106093301yarn add @medusajs/promotion@2.1.4-snapshot-20250106093301yarn add @medusajs/auth-emailpass@2.1.4-snapshot-20250106093301yarn add @medusajs/auth-github@2.1.4-snapshot-20250106093301yarn add @medusajs/auth-google@2.1.4-snapshot-20250106093301yarn add @medusajs/file-local@2.1.4-snapshot-20250106093301yarn add @medusajs/file-s3@2.1.4-snapshot-20250106093301yarn add @medusajs/fulfillment-manual@2.1.4-snapshot-20250106093301yarn add @medusajs/locking-postgres@2.1.4-snapshot-20250106093301yarn add @medusajs/locking-redis@2.1.4-snapshot-20250106093301yarn add @medusajs/notification-local@2.1.4-snapshot-20250106093301yarn add @medusajs/notification-sendgrid@2.1.4-snapshot-20250106093301yarn add @medusajs/payment-stripe@2.1.4-snapshot-20250106093301yarn add @medusajs/region@2.1.4-snapshot-20250106093301yarn add @medusajs/sales-channel@2.1.4-snapshot-20250106093301yarn add @medusajs/stock-location@2.1.4-snapshot-20250106093301yarn add @medusajs/store@2.1.4-snapshot-20250106093301yarn add @medusajs/tax@2.1.4-snapshot-20250106093301yarn add @medusajs/user@2.1.4-snapshot-20250106093301yarn add @medusajs/workflow-engine-inmemory@2.1.4-snapshot-20250106093301yarn add @medusajs/workflow-engine-redis@2.1.4-snapshot-20250106093301
|
sradevski
force-pushed
the
feat/add-support-custom-callback-uri-oauth
branch
from
bb98773 to
dcf41bf
Compare
|
I have already done some e2e tests and things are working as expected. |
adrien2p
approved these changes
Jan 6, 2025
packages/modules/providers/auth-github/integration-tests/__tests__/services.spec.ts
Outdated
Show resolved
Hide resolved
sradevski
force-pushed
the
feat/add-support-custom-callback-uri-oauth
branch
from
dcf41bf to
7273cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary so we can support different login pages based on the actor. This is also an intended approach to implementing oauth, where the client can control the callbackUrl (but the allowed redirects are limited within the Oauth app configuration)
For example, you might have a
user/github/callbackpage and acustomer/github/callbackpage, and where you redirect to would depend on which actor is doing the authentication.The PR also adds the
stateparameter as defined in the Oauth protocol.Note: If you have overridden the auth module definition in your medusa config, you will need to pass
Modules.CACHEas a dependency. This can be considered a breaking change due to that fact.We can also make it non-breaking by not storing the state and always returning the default callbackUrl as the state value. This reduces the security of the implementation, but can be an acceptable fallback.