chore: rename remote-query-entry-points.d.ts to query-entry-points.d.ts #10831
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 052dd18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thetutlage
commented
Jan 6, 2025
| /** | ||
| * Cleanup existing types directory before creating new artifacts | ||
| */ | ||
| await new FileSystem(typesDirectory).cleanup({ recursive: true }) |
There was a problem hiding this comment.
As a hygiene, we should always remove existing files and then create new artifacts.
There was a problem hiding this comment.
I think thats a good practice, but should we instead let each generator to clean up their own file to be sure we don't have other generated content that gets removed by mistake and not generated at the same time or from the same place?
There was a problem hiding this comment.
Yeah. That will be nice too. Right now, I was thinking of this flow
- The
.medusa/typesdirectory is dedicated to writing generated output. - We cleanup this directory before we generate any new output.
- Then dedicated actions will generate their output with clean slate.
But I agree, if one of those actions does not run under a certain condition, then the whole cleanup strategy won't work. For now, that's not the case, but I am happy to tweak the logic if you think we should address that right now 👍
carlos-r-l-rodrigues
approved these changes
Jan 6, 2025
adrien2p
approved these changes
Jan 6, 2025
olivermrbl
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FRMW-2804