Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa-payment-stripe): Migrate to the new Abstract payment service #1790

Merged
merged 33 commits into from
Oct 4, 2022
Merged

feat(medusa-payment-stripe): Migrate to the new Abstract payment service #1790

merged 33 commits into from
Oct 4, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jul 5, 2022 •
edited
Loading

What
Migrate the stripe payment plugin to use the new abstract payment service from the core. Also include the transactions fixes

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 16f2a23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-payment-stripe Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p changed the title feat(medusa-payment-stripe): refactor feat(medusa-payment-stripe): Migrate to the new Abstract payment service Jul 5, 2022
@adrien2p adrien2p marked this pull request as ready for review July 13, 2022 09:57
@adrien2p adrien2p requested a review from a team as a code owner July 13, 2022 09:57
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from f342a1c to d22d874 Compare July 22, 2022 07:41
@adrien2p adrien2p requested a review from a team as a code owner July 22, 2022 07:41
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch from 767dbb4 to 2246664 Compare July 22, 2022 08:05
@adrien2p adrien2p self-assigned this Jul 22, 2022
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch 2 times, most recently from 52636bf to 4666e91 Compare August 5, 2022 09:50
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch from 2246664 to 5eb101d Compare August 5, 2022 12:57
@adrien2p adrien2p mentioned this pull request Aug 5, 2022
Closed
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from 95eade2 to 52e091a Compare August 5, 2022 14:13
@olivermrbl olivermrbl force-pushed the feat-paymentServiceMigration branch from 52e091a to eb1b65d Compare August 7, 2022 11:01
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from eb1b65d to c4c5ab9 Compare August 8, 2022 07:22
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch 2 times, most recently from 510d84e to e677af0 Compare August 8, 2022 09:41
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from 011d2f8 to b7f0733 Compare August 8, 2022 12:49
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch from df4b7b6 to 0da4e16 Compare August 8, 2022 12:52
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from b7f0733 to 4dcb2bb Compare August 9, 2022 07:21
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch 4 times, most recently from c4d0677 to 2fd9f35 Compare August 9, 2022 08:48
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration branch from a24f225 to e6e2df5 Compare August 9, 2022 09:03
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch from 2fd9f35 to 7fdccca Compare August 9, 2022 09:04
adrien2p and others added 23 commits September 28, 2022 11:13
@adrien2p
feat(medusa-payment-stripe): Improve transaction
936dc19
@adrien2p
feat(medusa-payment-stripe): fix mock
83af707
@adrien2p
feat(medusa-payment-stripe): Migrate new payment providers
bdcf633
@adrien2p
fix
6d887b2
@adrien2p
test(medusa): Fix unit tests
e828a9c
@adrien2p
feat(payments): Refactor core Payment related
91a22d2
@adrien2p
feat(medusa-payment-stripe): Migrate to the new Abstract payment service
f0a3848
@adrien2p
feat(medusa-payment-stripe): cleanup
850cab0
@adrien2p
feat(medusa-payment-stripe): transaction
c8ba54a
@adrien2p
cleanup
034cbc8
@adrien2p
feat(medusa-payment-stripe): Improve transaction
085503d
@olivermrbl @adrien2p
Create nine-trainers-protect.md
9b050da
@adrien2p
feat(medusa-payment-stripe): Remove duplicate instance of cart servic…
3d9bc8c 
…e on withTransaction
@adrien2p
feat(medusa-payment-stripe): Cart subscriber should use manager_ inst…
1ceaab8 
…ead of an atomic phase
@adrien2p
feat(medusa-payment-stripe): Remove generics from the abstract paymen…
29e2e45 
…t service
@adrien2p
cleanup
1ba7877
@adrien2p
fix: missing manager pass to super:
3c1e922
@adrien2p
fix: relation
761b4d8
@adrien2p
fix: missing gift card total selection
696c2a7
@adrien2p
feat(strip): Use cart idempotency key for the webhook
d8f3278
@adrien2p
add manager
8c91e80
@adrien2p
revert stripe hook
151a49d
@adrien2p
fix ban contact import
a1e962a
@adrien2p adrien2p force-pushed the feat-paymentServiceMigration-stripe2 branch from 7625515 to a1e962a Compare September 28, 2022 09:13
olivermrbl
olivermrbl reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @adrien2p 💪

I believe we should move ahead with these changes as we are not introducing any new concepts or modifications to our interfaces - something we plan to do soon though.

Judging from the lines of code this seems dangerous to merge as it touches one of the most sensitive domains for merchants, but almost all changes are renamings or test adjustments. The important parts are the introduction of entity managers in the PP plugins and the use the withTransaction which will remove critical errors related to transaction management.

I would like @srindom to also sign off on it, as we've been going back and forth on this for quite some time.

@olivermrbl olivermrbl merged commit df62e61 into develop Oct 4, 2022
@olivermrbl olivermrbl deleted the feat-paymentServiceMigration-stripe2 branch October 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@srindom srindom srindom approved these changes

Assignees

@adrien2p adrien2p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @olivermrbl @srindom