-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setup price list import #2210
Conversation
🦋 Changeset detectedLatest commit: a579131 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice 💪
I added a couple of questions/suggestions which are non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
computerizeAmount
utility to convert human format to DB format)clearPrices
method in the PriceListService that can be used to delete all prices in a price list.Usage
Note: the import strategy will delete all existing prices in the price list, before creating the prices as specified by the import file.
Testing
batchJob.result.errors
Fixes CORE-590