Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infer MA currency on PL create #2232

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 19, 2022

What

  • a MoneyAmount record can be created with either providing region or currency. MA records cannot be inserted in the DB without currency due to not null constraints therefore the currency needs to be inferred from provided region

How

  • by using the same utility that fixes this issue on PL update

Testing

  • extend the "create PL" integration test to handle a MA with a region

FIXES CORE-525

@fPolic fPolic requested a review from a team as a code owner September 19, 2022 13:29
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

⚠️ No Changeset found

Latest commit: 1a7425d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - w. a small nit in how the test is being set up up to you if you want to fix :)

integration-tests/api/__tests__/admin/price-list.js Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit de85a97 into develop Sep 19, 2022
@kodiakhq kodiakhq bot deleted the fix/pl-infer-currency-on-update branch September 19, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants