Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Query SalesChannel Products in storefront #2272

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Sep 29, 2022

What

  • Adds the ability to query products in a sales channel from a storefront
  • Adds feature flag decorator to query param sales_channel_id in GET /admin/products as the feature is still guarded

Tests

  • Retrieve products in specific channel
  • Retrieve products in multiple channels
  • Retrieve all products when no channel is defined

Fixes CORE-602.

@olivermrbl olivermrbl requested a review from a team as a code owner September 29, 2022 10:00
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: 0831627

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srindom
Copy link
Collaborator

srindom commented Sep 29, 2022

@olivermrbl - maybe add a changeset?

@olivermrbl
Copy link
Contributor Author

olivermrbl commented Sep 29, 2022

maybe add a changeset?

PRs that include changes guarded by feature flags generally should not have a changeset

@olivermrbl olivermrbl merged commit 8797a14 into develop Sep 29, 2022
@olivermrbl olivermrbl deleted the fix/query-products-in-sales-channel branch September 29, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants