feat(medusa): Trim discount code on insert and retrieve #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 48176d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
olivermrbl
commented
Oct 6, 2022
| @@ -277,7 +275,7 @@ class DiscountService extends TransactionBaseService { | |||
| const manager = this.manager_ | |||
| const discountRepo = manager.getCustomRepository(this.discountRepository_) | |||
|
|
|||
| const normalizedCode = discountCode.toUpperCase() | |||
| const normalizedCode = discountCode.toUpperCase().trim() | |||
There was a problem hiding this comment.
comment: This is in retrieveByCode
olivermrbl
commented
Oct 6, 2022
| @@ -212,8 +212,6 @@ class DiscountService extends TransactionBaseService { | |||
| const discountRule = ruleRepo.create(validatedRule) | |||
| const createdDiscountRule = await ruleRepo.save(discountRule) | |||
|
|
|||
| discount.code = discount.code!.toUpperCase() | |||
|
|
|||
| const created: Discount = discountRepo.create( | |||
There was a problem hiding this comment.
comment: Removed from create as we are using beforeInsert in the model
srindom
reviewed
Oct 6, 2022
| discount.code = discount.code!.toUpperCase() | ||
|
|
||
| const created: Discount = discountRepo.create( |
There was a problem hiding this comment.
question: why is this removed?
There was a problem hiding this comment.
Sorry didnt see your comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.