-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add zoom functionality on images #2403
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! In addition to the comments I added below, can you change the z-index
of .medium-zoom-overlay
and .medium-zoom-image--opened
to z-index: var(--ifm-z-index-overlay);
? You should be able to add it in src/css/custom.css
. That way the sidebar doesn't appear when the pic is zoomed.
www/docs/docusaurus.config.js
Outdated
container: { | ||
left: 250, | ||
right: 40 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? I removed it and nothing changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had done this to zoom in the image inside the text container and not overflow over the sidebar, but I will make the appropriate changes in the z-index
Sure! I will make the changes |
Hi @shahednasser, I have done the suggested changes. Please have a look. |
@aniketh-varma there seems to be an issue with |
Sure! I will do the same. |
Awesome thanks a lot! 🙏🏻 @aniketh-varma |
Closes #2393
Added zoom functionality on images in the documentation page using the docusaurus-plugin-image-zoom plugin.
The changes will install the docusaurus-plugin-image-zoom plugin and configure the same.
I have tested the changes locally and did not encounter anything breaking.
Please feel free to suggest any changes. Thanks!