Feat/add discount condition batch #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 939af44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
force-pushed
the
feat/add-discount-condition-batch
branch
from
7021b62 to
fe784e4
Compare
adrien2p
requested review from
carlos-r-l-rodrigues,
fPolic,
olivermrbl,
pKorsholm and
srindom
srindom
reviewed
Oct 12, 2022
packages/medusa/src/api/routes/admin/discounts/add-items-to-condition-batch.ts
Outdated
Show resolved
Hide resolved
olivermrbl
reviewed
Oct 13, 2022
packages/medusa/src/api/routes/admin/discounts/add-resources-to-condition-batch.ts
Outdated
Show resolved
Hide resolved
…leanup of discounts and discount conditions end points
adrien2p
force-pushed
the
feat/add-discount-condition-batch
branch
from
676b52e to
939af44
Compare
This was referenced Oct 17, 2022
Closed
ymaheshwari1
pushed a commit
to ymaheshwari1/medusa
that referenced
this pull request
Oct 26, 2022
* feat(medusa): Allow to add items to a discount condition by batch + cleanup of discounts and discount conditions end points * style(medusa): cleanup catch and log * feat(medusa-react, medusa-js): Add support to add item batch to discount condition * cleanup * cleanup * rename items to resources * fix(medusa-js): url * Create fast-suns-repair.md * update naming * tests(integration): Update tests to reflect API changes * feat(medusa): Delete a condition should be idempotent on discount and condition * revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tests
FIXES CORE-608