Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Support batch remove resources on discount condition #2444

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

adrien2p
Copy link
Member

what

  • Add support to remove resources by batch on discount conditions
  • Add support on medusa-js and medusa-react

Tests

  • Add integration tests to validate that the resources have been deleted and the length is the one expected
  • Add unit tests on medusa react

FIXES CORE-609

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: c90d1e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/medusa-js Patch
medusa-react Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 14, 2022 11:47
@adrien2p adrien2p requested a review from a team as a code owner October 14, 2022 11:47
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 4841115 into develop Oct 17, 2022
@kodiakhq kodiakhq bot deleted the feat/discount-condition-remove-batch branch October 17, 2022 09:03
ymaheshwari1 pushed a commit to ymaheshwari1/medusa that referenced this pull request Oct 26, 2022
…edusajs#2444)

**what**
- Add support to remove resources by batch on discount conditions
- Add support on medusa-js and medusa-react

**Tests**
- Add integration tests to validate that the resources have been deleted and the length is the one expected
- Add unit tests on medusa react

FIXES CORE-609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants