feat: development server #2448

carlos-r-l-rodrigues · 2022-10-14T15:18:11Z

What:

Initial iteration for a simple development server of medusa core.
yarn run develop:create:db - Creates the database and seed it.
yarn run develop - Initialize the core as a server and auto reload when files are changed.

changeset-bot · 2022-10-14T15:18:13Z

⚠️ No Changeset found

Latest commit: 21743e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p · 2022-10-14T16:09:12Z

Seams pretty cool from a first look, i ll look at deeper next week 💪

…into feat/development-server

srindom · 2022-10-18T11:52:32Z

Is the idea with this PR that you can do yarn develop while working on Medusa to avoid having a "dummy-project" that you run medusa-dev in?

carlos-r-l-rodrigues · 2022-10-18T13:59:32Z

Is the idea with this PR that you can do yarn develop while working on Medusa to avoid having a "dummy-project" that you run medusa-dev in?

The idea is to have a develop mode to medusa core and all the built-in plugins. Currently we have no easy way to update a plugin or create a new endpoint and easily test it while developing.
This PR will run ts-node to execute all the files directly from the /src folder and auto reload them when something has changed.
All the endpoints will be accessible so you can manually trigger requests to test.

srindom · 2022-10-19T07:23:52Z

I get this when yarn run develop:create:db

srindom · 2022-10-19T07:23:59Z

Creating DB...
/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/src/error/TypeORMError.ts:7
        super(message);
        ^
QueryFailedError: template database "medusa-integration-template" does not exist
    at QueryFailedError.TypeORMError [as constructor] (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/src/error/TypeORMError.ts:7:9)
    at new QueryFailedError (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/src/error/QueryFailedError.ts:9:9)
    at PostgresQueryRunner.<anonymous> (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/typeorm/src/driver/postgres/PostgresQueryRunner.ts:263:19)
    at step (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/tslib/tslib.js:144:27)
    at Object.throw (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/tslib/tslib.js:125:57)
    at rejected (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/tslib/tslib.js:116:69)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  query: 'CREATE DATABASE "development" TEMPLATE "medusa-integration-template";',
  parameters: undefined,
  driverError: error: template database "medusa-integration-template" does not exist
      at Parser.parseErrorMessage (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/pg-protocol/src/parser.ts:369:69)
      at Parser.handlePacket (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/pg-protocol/src/parser.ts:188:21)
      at Parser.parse (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/pg-protocol/src/parser.ts:103:30)
      at Socket.<anonymous> (/Users/sebastianrindom/Developer/medusa/medusa-js/node_modules/pg-protocol/src/index.ts:7:48)
      at Socket.emit (node:events:513:28)
      at Socket.emit (node:domain:489:12)
      at addChunk (node:internal/streams/readable:315:12)
      at readableAddChunk (node:internal/streams/readable:289:9)
      at Socket.Readable.push (node:internal/streams/readable:228:10)
      at TCP.onStreamRead (node:internal/stream_base_commons:190:23) {
    length: 119,
    severity: 'ERROR',
    code: '3D000',
    detail: undefined,
    hint: undefined,
    position: undefined,
    internalPosition: undefined,
    internalQuery: undefined,
    where: undefined,
    schema: undefined,
    table: undefined,
    column: undefined,
    dataType: undefined,
    constraint: undefined,
    file: 'dbcommands.c',
    line: '357',
    routine: 'createdb'
  },
  length: 119,
  severity: 'ERROR',
  code: '3D000',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'dbcommands.c',
  line: '357',
  routine: 'createdb'
}

…into feat/development-server

carlos-r-l-rodrigues · 2022-10-19T11:46:58Z

I get this when yarn run develop:create:db

Fixed. Thanks

…into feat/development-server

olivermrbl · 2022-10-20T10:19:26Z

I am faced with the following error message when trying to seed the DB:

Creating DB...
Creating DB. DONE
Seeding DB...
Error TypeError: this.subQuery is not a function
    at InsertQueryBuilder.QueryBuilder.createFromAlias (/Users/oliverjuhl/Desktop/medusa/core/node_modules/src/query-builder/QueryBuilder.ts:599:127)
    at InsertQueryBuilder.into (/Users/oliverjuhl/Desktop/medusa/core/node_modules/src/query-builder/InsertQueryBuilder.ts:187:32)
    at EntityManager.<anonymous> (/Users/oliverjuhl/Desktop/medusa/core/node_modules/src/entity-manager/EntityManager.ts:466:14)
    at step (/Users/oliverjuhl/Desktop/medusa/core/node_modules/tslib/tslib.js:144:27)
    at Object.next (/Users/oliverjuhl/Desktop/medusa/core/node_modules/tslib/tslib.js:125:57)
    at /Users/oliverjuhl/Desktop/medusa/core/node_modules/tslib/tslib.js:118:75
    at new Promise (<anonymous>)
    at __awaiter (/Users/oliverjuhl/Desktop/medusa/core/node_modules/tslib/tslib.js:114:16)
    at EntityManager.insert (/Users/oliverjuhl/Desktop/medusa/core/node_modules/typeorm/entity-manager/EntityManager.js:277:38)
    at /Users/oliverjuhl/Desktop/medusa/core/integration-tests/development/database/user.js:10:17
Seeding DB... DONE

From what I can find via Google search, this is likely to be related to a couple of missing environment variables, but before proceeding with the investigation, I wanted to check if you'd experienced the same issue before?

olivermrbl · 2022-10-20T18:28:14Z

This is really awesome @carlos-r-l-rodrigues!

How should we proceed?

We could add additional seeders, or let more from the team spin up the development server to ensure it works in more local environments. Let me know what you think :)

carlos-r-l-rodrigues · 2022-10-20T18:44:59Z

Ideally we have more people trying it before merging this, and following that we can have another PR seeding the DB with all the required data.
Next steps we add support to feature flags on the seeders.

olivermrbl · 2022-10-20T19:00:04Z

Ideally we have more people trying it before merging this

Sounds good!

olivermrbl · 2022-10-21T12:55:05Z

Would be great to run a couple more tests on local machines. Is anyone up for the task? @medusajs/engineering

olivermrbl

LGTM!

feat: development server

93729ff

carlos-r-l-rodrigues added 2 commits October 14, 2022 12:20

fix: watch path

ae0b27c

fix: ignore if not env isn't dev

499a626

carlos-r-l-rodrigues and others added 9 commits October 17, 2022 08:11

fix: ignore path isTest

d7d7068

Merge branch 'develop' into feat/development-server

def042a

fix: db connect if disconnected

f6bd5a1

fix: node env cli tests

64cb8d3

fix: medusa interfaces

faacc5e

Merge branch 'develop' into feat/development-server

319e376

chore: medusa core utils

aa0684e

Merge branch 'feat/development-server' of github.com:medusajs/medusa …

ca9dd0c

…into feat/development-server

fix: close db conn and clean typeorm modules

064d8f1

carlos-r-l-rodrigues marked this pull request as ready for review October 17, 2022 20:56

carlos-r-l-rodrigues requested a review from a team as a code owner October 17, 2022 20:56

feat: development config file

611e645

carlos-r-l-rodrigues and others added 2 commits October 18, 2022 13:00

fix: check folder inside src

17f4bf8

Merge branch 'develop' into feat/development-server

89b8cbf

srindom closed this Oct 19, 2022

srindom reopened this Oct 19, 2022

carlos-r-l-rodrigues and others added 3 commits October 19, 2022 08:45

fix: db creation

a310de0

Merge branch 'feat/development-server' of github.com:medusajs/medusa …

cf1209d

…into feat/development-server

Merge branch 'develop' into feat/development-server

18aef9d

chore: .env

25699a6

carlos-r-l-rodrigues and others added 7 commits October 19, 2022 10:53

Merge branch 'feat/development-server' of github.com:medusajs/medusa …

e08d1fe

…into feat/development-server

fix: windows path

6a82477

chore: local services

1acff7f

chore: NODE_ENV development

194ab39

fix: create db env

d54eab4

fix: env vars

872f82b

Merge branch 'develop' into feat/development-server

dcd7d6e

olivermrbl and others added 3 commits October 20, 2022 15:53

fix: replacePath in dev-require.js

53302a0

Merge branch 'develop' into feat/development-server

a213208

Merge branch 'develop' into feat/development-server

23f6f4a

carlos-r-l-rodrigues and others added 2 commits October 20, 2022 16:00

chore: server port as env var

b2aa3ee

Merge branch 'develop' into feat/development-server

021a695

Merge branch 'develop' into feat/development-server

21743e6

olivermrbl approved these changes Oct 21, 2022

View reviewed changes

olivermrbl merged commit b88cef2 into develop Oct 21, 2022

olivermrbl deleted the feat/development-server branch October 21, 2022 13:53

ymaheshwari1 pushed a commit to ymaheshwari1/medusa that referenced this pull request Oct 26, 2022

feat: Development server for core + plugins (medusajs#2448)

4806d3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: development server #2448

feat: development server #2448

carlos-r-l-rodrigues commented Oct 14, 2022

changeset-bot bot commented Oct 14, 2022 •

edited

Loading

adrien2p commented Oct 14, 2022

srindom commented Oct 18, 2022 •

edited

Loading

carlos-r-l-rodrigues commented Oct 18, 2022 •

edited

Loading

srindom commented Oct 19, 2022

srindom commented Oct 19, 2022 •

edited

Loading

carlos-r-l-rodrigues commented Oct 19, 2022

olivermrbl commented Oct 20, 2022 •

edited

Loading

olivermrbl commented Oct 20, 2022

carlos-r-l-rodrigues commented Oct 20, 2022

olivermrbl commented Oct 20, 2022

olivermrbl commented Oct 21, 2022

olivermrbl left a comment

feat: development server #2448

feat: development server #2448

Conversation

carlos-r-l-rodrigues commented Oct 14, 2022

changeset-bot bot commented Oct 14, 2022 • edited Loading

⚠️ No Changeset found

adrien2p commented Oct 14, 2022

srindom commented Oct 18, 2022 • edited Loading

carlos-r-l-rodrigues commented Oct 18, 2022 • edited Loading

srindom commented Oct 19, 2022

srindom commented Oct 19, 2022 • edited Loading

carlos-r-l-rodrigues commented Oct 19, 2022

olivermrbl commented Oct 20, 2022 • edited Loading

olivermrbl commented Oct 20, 2022

carlos-r-l-rodrigues commented Oct 20, 2022

olivermrbl commented Oct 20, 2022

olivermrbl commented Oct 21, 2022

olivermrbl left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 14, 2022 •

edited

Loading

srindom commented Oct 18, 2022 •

edited

Loading

carlos-r-l-rodrigues commented Oct 18, 2022 •

edited

Loading

srindom commented Oct 19, 2022 •

edited

Loading

olivermrbl commented Oct 20, 2022 •

edited

Loading