Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OE item change conflict #2470

Closed
wants to merge 3 commits into from
Closed

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 19, 2022

What

  • return 409 if there is UIDX conflict on order edit item change creation

FIXES CORE-717

@fPolic fPolic requested a review from a team as a code owner October 19, 2022 14:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

⚠️ No Changeset found

Latest commit: f4c7711

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srindom
Copy link
Collaborator

srindom commented Oct 19, 2022

We might not need this any longer given @adrien2p's fix error handler here: #2467

@adrien2p
Copy link
Member

adrien2p commented Oct 19, 2022

We might not need this any longer given @adrien2p's fix error handler here: #2467

@fPolic indeed @srindom is right. The changes in the referenced pr generalise the format exception, if a query fail and throw the error handler will take charge of handling the translation of the error according to our needs 👌 don’t hesitate to give your feedback

@srindom
Copy link
Collaborator

srindom commented Oct 19, 2022

thanks @adrien2p - will close this :)

@srindom srindom closed this Oct 19, 2022
@fPolic fPolic deleted the fix/item-change-conflict branch January 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants