feat(medusa): Align product import and export #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e2738c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
force-pushed
the
feat/export-import-alignment
branch
from
453c4e2 to
4e20f83
Compare
olivermrbl
requested changes
Oct 20, 2022
There was a problem hiding this comment.
Great work so far @adrien2p!
I've identified a couple of things to change. Also, I am faced with the following error upon exporting products, changing product title, and import the same file again:
Error: The csv file parsing failed due to: Unable to treat column Sales channel 1 Name from the csv file. No target column found in the provided schema
at ProductImportStrategy.<anonymous> (/Users/oliverjuhl/Desktop/medusa/medusa-import/node_modules/@medusajs/medusa/dist/strategies/batch-jobs/product/import.js:349:31)
at step (/Users/oliverjuhl/Desktop/medusa/medusa-import/node_modules/@medusajs/medusa/dist/strategies/batch-jobs/product/import.js:59:23)
at Object.throw (/Users/oliverjuhl/Desktop/medusa/medusa-import/node_modules/@medusajs/medusa/dist/strategies/batch-jobs/product/import.js:40:53)
at rejected (/Users/oliverjuhl/Desktop/medusa/medusa-import/node_modules/@medusajs/medusa/dist/strategies/batch-jobs/product/import.js:32:65)
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
type: 'invalid_data',
code: undefined,
date: 2022-10-20T11:10:07.886Z
}My server has Sales Channel feature enabled, which might be the culprit to the issue.
packages/medusa/src/strategies/batch-jobs/product/types/columns-definition.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/strategies/batch-jobs/product/types/columns-definition.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/strategies/batch-jobs/product/types/columns-definition.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/strategies/batch-jobs/product/types/columns-definition.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/strategies/batch-jobs/product/types/columns-definition.ts
Show resolved
Hide resolved
olivermrbl
reviewed
Oct 20, 2022
packages/medusa/src/strategies/__tests__/batch-jobs/product/export.ts
Outdated
Show resolved
Hide resolved
olivermrbl
approved these changes
Oct 20, 2022
|
Oh actually, can I get you to add a changeset 😅 @adrien2p |
Closed
ymaheshwari1
pushed a commit
to ymaheshwari1/medusa
that referenced
this pull request
Oct 26, 2022
**What** Create a data structure that facilitate the addition of new column descriptor for both export and import and ensure that the column name is shared between bother import and export to facilitate the import with an exported file. **Tests** Add an additional integration tests that export a file, update the data, and re import the same file FIXES CORE-716 FIXES CORE-713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Create a data structure that facilitate the addition of new column descriptor for both export and import and ensure that the column name is shared between bother import and export to facilitate the import with an exported file.
Tests
Add an additional integration tests that export a file, update the data, and re import the same file
FIXES CORE-716
FIXES CORE-713