Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): Sales Channel migration script #2521

Merged
merged 1 commit into from
Nov 2, 2022
Merged

fix(medusa): Sales Channel migration script #2521

merged 1 commit into from
Nov 2, 2022

Conversation

olivermrbl
Copy link
Contributor

When attempting to retrieve the store entity Typeorm's getOne returns undefined, while getRawOne returns the expected entity.

Simply changing to use the raw query and adding types resolves the issue.

Also fixes an issue with the tuples being inserted in product_sales_channel table

@olivermrbl olivermrbl requested a review from adrien2p November 2, 2022 10:50
@olivermrbl olivermrbl requested a review from a team as a code owner November 2, 2022 10:50
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

⚠️ No Changeset found

Latest commit: cb20cdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl requested a review from srindom November 2, 2022 10:51
adrien2p
adrien2p approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! weird behaviour though

@olivermrbl olivermrbl merged commit 684f68c into develop Nov 2, 2022
@olivermrbl olivermrbl deleted the fix/sc-migration-script branch November 2, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p adrien2p approved these changes

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olivermrbl @srindom @adrien2p @carlos-r-l-rodrigues