Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Order/Cart decorate totals should assign the items totals #2546

Merged
merged 13 commits into from
Nov 7, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 4, 2022

What

If total or subtotal are selected then get the line item totals and assign them to the items.

I also had to remove the totals from the cart update service since they are not used and that by having them the items get the tax lines attached and since the update is performed by passing the entire cart, it is trying to insert the tax lines with the cart update

Tests

Add an integration tests to validate that the items includes the totals in the order and draft order

FIXES CORE-687

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2022

⚠️ No Changeset found

Latest commit: d985d7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p changed the title fix(medusa): Order decorate totals should assign the items totals fix(medusa): Order/Cart decorate totals should assign the items totals Nov 4, 2022
@adrien2p adrien2p force-pushed the fix/order-decorate-total branch from e224154 to 9d6537d Compare November 4, 2022 10:31
@adrien2p adrien2p force-pushed the fix/order-decorate-total branch from 3668711 to 85951fb Compare November 4, 2022 11:11
@olivermrbl olivermrbl closed this Nov 4, 2022
@olivermrbl olivermrbl reopened this Nov 4, 2022
@adrien2p adrien2p marked this pull request as ready for review November 7, 2022 09:36
@adrien2p adrien2p requested a review from a team as a code owner November 7, 2022 09:36
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 129ad4b into develop Nov 7, 2022
@kodiakhq kodiakhq bot deleted the fix/order-decorate-total branch November 7, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants