-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa): Order/Cart decorate totals should assign the items totals #2546
Conversation
|
e224154
to
9d6537d
Compare
3668711
to
85951fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
If
total
orsubtotal
are selected then get the line item totals and assign them to the items.I also had to remove the totals from the cart update service since they are not used and that by having them the items get the tax lines attached and since the update is performed by passing the entire cart, it is trying to insert the tax lines with the cart update
Tests
Add an integration tests to validate that the items includes the totals in the order and draft order
FIXES CORE-687