-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa-payment-stripe): handle webhook sirialization failure #2607
Conversation
🦋 Changeset detectedLatest commit: 66521dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@srindom could you give me your opinion on the webhook handler method I have created to wrap the logic under the hood so that a plugin creator does not have to handle it. I am not sure about putting it in the payment provider but since it is our link to the payment provider plugin I thought it would make sense. Let me know. |
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221115142411 yarn add medusa-payment-stripe@0.0.0-snapshot-20221115142411
|
Tested by a user as well https://discord.com/channels/876835651130097704/1041787790297419786/1042211674414915654 |
@olivermrbl would you happen to know why the database pipeline is failing? |
647339d
to
bd54ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WIP: ready only for snap
What
Handle stripe webhook serialization failure on
payment_intent.amount_capturable_updated
eventFIXES CORE-796