Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-payment-stripe): handle webhook sirialization failure #2607

Merged
merged 12 commits into from
Nov 20, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 15, 2022

WIP: ready only for snap

What

Handle stripe webhook serialization failure on payment_intent.amount_capturable_updated event

FIXES CORE-796

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: 66521dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-payment-stripe Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review November 15, 2022 11:59
@adrien2p adrien2p requested a review from a team as a code owner November 15, 2022 11:59
@adrien2p
Copy link
Member Author

adrien2p commented Nov 15, 2022

@srindom could you give me your opinion on the webhook handler method I have created to wrap the logic under the hood so that a plugin creator does not have to handle it. I am not sure about putting it in the payment provider but since it is our link to the payment provider plugin I thought it would make sense. Let me know.

@adrien2p
Copy link
Member Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@0.0.0-snapshot-20221115142411
yarn add medusa-payment-stripe@0.0.0-snapshot-20221115142411

Latest commit: 3aa0827

@adrien2p
Copy link
Member Author

adrien2p commented Nov 16, 2022

@adrien2p
Copy link
Member Author

@olivermrbl would you happen to know why the database pipeline is failing?

@adrien2p adrien2p force-pushed the fix/stripe-webhook-issue branch from 647339d to bd54ef6 Compare November 16, 2022 20:06
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit e09f6e8 into develop Nov 20, 2022
@olivermrbl olivermrbl deleted the fix/stripe-webhook-issue branch November 20, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants