feat(medusa): Performance improvement of listing shipping options #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 998bb94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.6.4-snapshot-20221118155333yarn add medusa-payment-stripe@1.1.48-snapshot-20221118155333yarn add medusa-plugin-discount-generator@1.1.20-snapshot-20221118155333yarn add medusa-plugin-restock-notification@1.0.1-snapshot-20221118155333
|
adrien2p
changed the title
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.6.4-snapshot-20221118173847yarn add medusa-payment-stripe@1.1.48-snapshot-20221118173847yarn add medusa-plugin-discount-generator@1.1.20-snapshot-20221118173847yarn add medusa-plugin-restock-notification@1.0.1-snapshot-20221118173847
|
|
Used artillery for little load test + pm2
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.6.4-snapshot-20221119094555yarn add medusa-payment-stripe@1.1.48-snapshot-20221119094555yarn add medusa-plugin-discount-generator@1.1.20-snapshot-20221119094555yarn add medusa-plugin-restock-notification@1.0.1-snapshot-20221119094555
|
|
New results
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.6.4-snapshot-20221120001748yarn add medusa-payment-stripe@1.1.48-snapshot-20221120001748yarn add medusa-plugin-discount-generator@1.1.20-snapshot-20221120001748yarn add medusa-plugin-restock-notification@1.0.1-snapshot-20221120001748
|
olivermrbl
changed the title
olivermrbl
approved these changes
Nov 20, 2022
olivermrbl
pushed a commit
that referenced
this pull request
Nov 22, 2022
adrien2p
added a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prod response time (named "rp" below): 7s
Local rp: 4.5s
After changes
Local rp: 16-60ms
Overall improvement up to x250
The side effect of this should be felt on every endpoint rp
FIXES CORE-813