fix(medusa): Separate JWT auth strategies per domain #2646
Conversation
🦋 Changeset detectedLatest commit: f9525ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/snapshot-this |
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221121194915yarn add medusa-core-utils@0.0.0-snapshot-20221121194915
|
olivermrbl
changed the title
olivermrbl
changed the title
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221121211122yarn add medusa-core-utils@0.0.0-snapshot-20221121211122
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221121213619yarn add medusa-core-utils@0.0.0-snapshot-20221121213619
|
olivermrbl
force-pushed
the
fix/jwt-strategies
branch
from
33e49e2 to
38a60bd
Compare
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221121224430yarn add medusa-core-utils@0.0.0-snapshot-20221121224430
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221121230632yarn add medusa-core-utils@0.0.0-snapshot-20221121230632
|
olivermrbl
force-pushed
the
fix/jwt-strategies
branch
from
e9f6af0 to
c7bca61
Compare
|
/snapshot-this |
olivermrbl
force-pushed
the
fix/jwt-strategies
branch
from
417c426 to
24317f7
Compare
olivermrbl
force-pushed
the
fix/jwt-strategies
branch
from
ea83b19 to
91265b8
Compare
olivermrbl
force-pushed
the
fix/jwt-strategies
branch
from
91265b8 to
a1d6646
Compare
|
/snapshot-this |
olivermrbl
requested review from
adrien2p,
carlos-r-l-rodrigues,
fPolic and
kasperkristensen
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@0.0.0-snapshot-20221122082111yarn add medusa-core-utils@0.0.0-snapshot-20221122082111
|
|
|
||
| export default { | ||
| authenticate, | ||
| authenticateCustomer, | ||
| authenticateCustomerOrThrow, |
There was a problem hiding this comment.
suggestion: requireAuthenticateCustomer just to avoid confusion for the consumer
|
@adrien2p done 😎 |
perfect 🚀 it looks like we've done it 😍 |
olivermrbl
changed the title
| import passport from "passport" | ||
|
|
||
| export default (): RequestHandler => { | ||
| return (req: Request, res: Response, next: NextFunction): void => { |
There was a problem hiding this comment.
thought(non-blocking): when this is called the authenticateCustomer middleware will already be applied. This means the JWT is parsed. We could just verify with a simple if that the customer has been parsed. Not an important change but just wanted to highlight that this might be duplicate work.
There was a problem hiding this comment.
You are right, I would just say that a user could use them independently and therefore I am not sure we should go with the idea that we know that internally it has already been parsed. Wdyt?
**What** Separate JWT auth strategies per domain Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com> Co-authored-by: Adrien de Peretti <25098370+adrien2p@users.noreply.github.com>
What
Separate JWT auth strategies per domain