-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Performance improvements of Carts domain #2648
Conversation
🦋 Changeset detectedLatest commit: 17c90c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eb8ff59
to
0d84397
Compare
f7e7338
to
6f0137a
Compare
c4a65ff
to
5656f43
Compare
426d8c6
to
9062b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
a00fe15
to
be706df
Compare
I ve closed and reopened the pr to trigger the pipeline to run again |
What
I have created a new method on the cart service which is
addLineItems
, allowing a user to add one or multiple items in an optimized way. Also updated thegenerate
method from the line item service which now also accept a object data or a collection of data which. Various places have been optimized and cache support has been added to the price selection strategy.The overall optimization allows to reach another 9000% improvement in the response time as a median (Creating a cart with 6 items):
FIXES CORE-722